Fix recycle dependency

Author: lunny

modules/git/repo.go

@@ -284,7 +284,9 @@ func (repo *Repository) CreateBundle(ctx context.Context, commit string, out io.
 	if err != nil {
 		return err
 	}
-	defer util.RemoveAll(tmp)
+	defer func() {
+		_ = util.RemoveAll(tmp)
+	}()
 
 	env := append(os.Environ(), "GIT_OBJECT_DIRECTORY="+filepath.Join(repo.Path, "objects"))
 	_, _, err = NewCommand(ctx, "init", "--bare").RunStdString(&RunOpts{Dir: tmp, Env: env})

modules/util/legacy_test.go

@@ -11,15 +11,13 @@ import (
 	"testing"
 	"time"
 
-	"code.gitea.io/gitea/modules/setting"
-
 	"github.com/stretchr/testify/assert"
 )
 
 func TestCopyFile(t *testing.T) {
 	testContent := []byte("hello")
 
-	tmpDir := setting.TempDir()
+	tmpDir := os.TempDir()
 	now := time.Now()
 	srcFile := fmt.Sprintf("%s/copy-test-%d-src.txt", tmpDir, now.UnixMicro())
 	dstFile := fmt.Sprintf("%s/copy-test-%d-dst.txt", tmpDir, now.UnixMicro())