fine tune

Author: wxiaoguang

services/lfs/server.go

@@ -77,7 +77,7 @@ func GetLFSAuthTokenWithBearer(opts AuthTokenOptions) (string, error) {
 	// Sign and get the complete encoded token as a string using the secret
 	tokenString, err := token.SignedString(setting.LFS.JWTSecretBytes)
 	if err != nil {
-		return "", fmt.Errorf("failed to sign token: %w", err)
+		return "", fmt.Errorf("failed to sign LFS JWT token: %w", err)
 	}
 	return "Bearer " + tokenString, nil
 }

services/repository/generate.go

@@ -55,6 +55,9 @@ var globalVars = sync.OnceValue(func() (ret struct {
 		{Name: "UPPER", Transform: strings.ToUpper},
 		{Name: "TITLE", Transform: util.ToTitleCase},
 	}
+
+	// invalid filename contents, based on https://github.com/sindresorhus/filename-reserved-regex
+	// "COM10" needs to be opened with UNC "\\.\COM10" on Windows, so itself is valid
 	ret.fileNameSanitizeRegexp = regexp.MustCompile(`(?i)[<>:"/\\|?*\x{0000}-\x{001F}]|^(con|prn|aux|nul|com\d|lpt\d)$`)
 	return ret
 })
@@ -336,7 +339,6 @@ func (gro GenerateRepoOptions) IsValid() bool {
 		gro.IssueLabels || gro.ProtectedBranch // or other items as they are added
 }
 
-// Sanitize user input to valid OS filenames, based on https://github.com/sindresorhus/filename-reserved-regex
 func filePathSanitize(s string) string {
 	fields := strings.Split(filepath.ToSlash(s), "/")
 	for i, field := range fields {

services/repository/generate_test.go

@@ -62,7 +62,10 @@ func TestFilePathSanitize(t *testing.T) {
 	assert.Equal(t, "_", filePathSanitize("CoM1"))
 	assert.Equal(t, "_", filePathSanitize("\u0000"))
 	assert.Equal(t, "目标", filePathSanitize("目标"))
-	assert.Equal(t, "目标", filePathSanitize("目标"))
+	// unlike filepath.Clean, it only sanitizes, doesn't change the separator layout
+	assert.Equal(t, "", filePathSanitize(""))
+	assert.Equal(t, ".", filePathSanitize("."))
+	assert.Equal(t, "/", filePathSanitize("/"))
 }
 
 func TestProcessGiteaTemplateFile(t *testing.T) {