terrible

Author: NorthRealm

services/mailer/mail_workflow_run.go

@@ -5,10 +5,6 @@ package mailer
 
 import (
 	"bytes"
-	"context"
-	"fmt"
-	"sort"
-
 	actions_model "code.gitea.io/gitea/models/actions"
 	"code.gitea.io/gitea/models/db"
 	repo_model "code.gitea.io/gitea/models/repo"
@@ -19,6 +15,9 @@ import (
 	"code.gitea.io/gitea/modules/translation"
 	"code.gitea.io/gitea/services/convert"
 	sender_service "code.gitea.io/gitea/services/mailer/sender"
+	"context"
+	"fmt"
+	"sort"
 )
 
 const tplWorkflowRun = "notify/workflow_run"
@@ -53,16 +52,13 @@ func sendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo_model.Rep
 	if err != nil {
 		log.Error("GetRunJobsByRunID: %v", err)
 		return
-	} else {
-		sort.SliceStable(jobs, func(i, j int) bool {
-			si := jobs[i].Status
-			sj := jobs[j].Status
-			if si == sj || si.IsSuccess() {
-				return false
-			}
-			return si < sj
-		})
 	}
+	sort.SliceStable(jobs, func(i, j int) bool {
+		si := jobs[i].Status
+		sj := jobs[j].Status
+		return !(si == sj || si.IsSuccess()) && si < sj
+	})
+
 	convertedJobs := make([]convertedWorkflowJob, 0, len(jobs))
 	for _, job := range jobs {
 		converted0, err := convert.ToActionWorkflowJob(ctx, repo, nil, job)