Push via ssh looks for custom/conf/app.ini at wrong path

[jmert]

• Gitea version (or commit ref): Gitea version 1.0.0+351-g8947b711
• Git version: git version 2.12.0
• Operating system: Arch Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Using Arch's gittea-git AUR package, a recent recompile-and-update broke my ability to push to my repositories. The error message looked like:

$ git push
Counting objects: 10, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.83 KiB | 0 bytes/s, done.
Total 10 (delta 4), reused 0 (delta 0)
remote: 2017/02/28 08:42:59 [W] Custom config '/usr/bin/custom/conf/app.ini' not found, ignore this if you're running first time
remote: 2017/02/28 08:42:59 [...a/modules/log/log.go:59 NewGitLogger()] [E] Failed to create dir /usr/bin/log/hooks: mkdir /usr/bin/log: permission denied
To host:user/repo.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'gitea@host:user/repo.git'

I eventually figured out a work-around to be to add into my gitea user's ~/.ssh/environment file:

GITEA_CUSTOM=/var/lib/gitea/custom

The systemd service file includes this environment, so the web service started just fine. Neither of gitea's git hooks nor the authorized_keys file it generates explicitly includes this environment variable.

Searching through my system's update logs, it appears the issue has crept in sometime between versions r4904.284c0160-1 which was working and r5007.8947b711-1 which I installed yesterday. (I apologize for having to use the AUR package's versioning instead of gitea's versioning, but that's all my package manager knows about).

[lunny]

The latest master version has a push bug which will be fixed by #1077. But I think that's not this one.
Could you cat your authorized_keys to see the command .../gitea serv. This command should include the custom app.ini parameter. And also please confirm your gitea's path is correct.

[jmert]

The authorized_keys entries all start with:

command="/usr/bin/gitea serv key-1 --config='/var/lib/gitea/custom/conf/app.ini'",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa 

I can confirm that my gitea binary is located at /usr/bin/gitea and that the custom configuration file is at /var/lib/gitea/custom/conf/app.ini.

(And for completeness, I also see #1073 / #1077 but that only presents itself once I've worked around the issue reported here. If I remove the ssh environment file, I can reliably have this problem instead.)

[francoism90]

Confirm here, on the latest commit push will cause an error on SSH. Version r4995.5bd22a2f-1 works fine.

[lunny]

Yes. so you have to remove your ssh environment file and patch #1077

[lunny]

@francoism90 do you have the same issue with @jmert ?

[lunny]

@jmert @francoism90 please help to confirm the latest #1077 fix this issue.

[jmert]

I manually applied the patch from #1077 on top of master (version 1.0.0+361-g9cb08a3c) and rebuilt within the AUR package specification. After updating, restarting, and removing the environment file, I again receive the error I originally reported.

tl;dr The patch in #1077 doesn't fix the issue for me.

(Once I restore the environment file, though, I can push a new branch, so that's a verify on my end for fixing #1073)

[lunny]

@jmert Thanks for your confirmation since I cannot reproduce it myself. I just sent another commit and I wish it could resolve your issue.

[francoism90]

@lunny Yes, same issue as @jmert (I'm the maintainer of the gitea-git package).

#1077
Should c.GlobalIsSet("config") be the first one to check, instead of c.IsSet("config")?
Don't know how custom variables are handled by Gitea, but is it correct that it checks for GITEA_CUSTOM in the default config first, and second the global set in a systemd service for example?