release find by tag returns 500 error

[cameronbraid]

git server version 1.13.1

When using the Get a release by tag name api call a 500 error is returned for a tag_name after git tag has been done but a release has not been created. The response is

{
"message": "user does not exist [uid: 0, name: , keyid: 0]",
"url": "https://git-dev.drivenow.com.au/api/swagger"
}

I suspect the cause is because there exists a record in the release table with the publisher_id=0

[noerw]

Can't reproduce this on try.gitea.io.
Please provide a way to reproduce the issue, otherwise we can't debug this.

[zeripath]

Or at least give us some logs from the gitea instance.

[cameronbraid]

I am using sqlite as database

the logs dont show anything more.. just the same user does not exist for id 0 - since the release.publisher_id col contains a 0 value

�[36m2021/01/17 13:00:38 �[0m�[32m...repo/release_tags.go:56:�[32mGetReleaseTag()�[0m �[1;31m[E]�[0m �[1mLoadAttributes�[0m: �[1muser does not exist [uid: 0, name: , keyid: 0]�[0m

�[36m2021/01/17 13:00:38 �[0mCompleted �[34mGET�[0m �[1m/api/v1/repos/drivenow/frontend/releases/tags/v8.0.13�[0m �[1;41m500�[0m �[1;41mInternal Server Error�[0m in �[1m62.717056ms�[0m

[cameronbraid]

Looks like try.gitea.io uses master as it has this code in there :

func (r *Release) loadAttributes(e Engine) error {
	var err error
	if r.Repo == nil {
		r.Repo, err = GetRepositoryByID(r.RepoID)
		if err != nil {
			return err
		}
	}
	if r.Publisher == nil {
		r.Publisher, err = getUserByID(e, r.PublisherID)
		if err != nil {
			if IsErrUserNotExist(err) {
				r.Publisher = NewGhostUser()
			} else {
				return err
			}
		}
	}
	return getReleaseAttachments(e, r)
}

where as v1.13.1 is missing the IsErrUserNotExist test

[noerw]

Thanks, good hint!
Looks like #12096 did a bugfix within a feature PR :| Will backport that to 1.13.2

[6543]

closed by #14375