500 error when when trying to transfer repository from user to organization

[witten]

• Gitea version (or commit ref): 1.15.2
• Git version: 2.30.2 (as part of Gitea container)
• Operating system: Debian 11 running official Gitea Docker container (based on Alpine 3.13.6), run via Docker Compose
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Browser: Firefox 91.0.2 (ad blockers disabled)
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No (tried moving a test repository to a pre-existing test organization)
• Log gist: https://gist.github.com/witten/5ee4772a7031ea5d6ce6e45ffa61e9ce

Description

When trying to transfer a repository from my user to an organization I own, I receive a 500 from Gitea and the transfer doesn't go through.

Potentially relevant: #10230

Screenshots

HTTP request payload

_csrf=REDACTED&action=transfer&repo_name=borgmatic&new_owner_name=borgmatic-collective

[zeripath]

Please read https://docs.gitea.io/en-us/logging-configuration/#debugging-problems

We need the logs for the 500

[witten]

I've just updated the linked gist as per your debugging instructions. It looks like the error in question is this:

2021/09/14 17:38:43 .../web/repo/setting.go:593:SettingsPost() [E] TransferOwnership: getCollaborators: user does not exist [uid: 38, name: , keyid: 0]

[zeripath]

OK so the error report is coming from:

gitea/routers/web/repo/setting.go

Line 593 in 659b946

ctx.ServerError("TransferOwnership", err)

but the error is actually created:

gitea/models/repo_transfer.go

Line 266 in 659b946

return fmt.Errorf("getCollaborators: %v", err)

and will actually come from:

gitea/models/repo_collaboration.go

Lines 88 to 91 in 659b946

	user, err := getUserByID(e, c.UserID)
	if err != nil {
	return nil, err
	}

Now the interesting part here is that this implies that there is a user (user id: 38) who is listed as a collaborator of that repo who is no longer in existence.

This is a db consistency issue but I think we should just handle this by ignoring this user.

[witten]

Interesting! I deleted a bunch of a spammers a while back, and it's possible that impacted a collaborator on the repo in question. So maybe this is a non-issue for other Gitea instances?

[zeripath]

Well it's kinda bad that this kills things - we should simply tolerate and not die.

I also don't think that our doctor will fix this inconsistency either so that needs fixing too.

[zeripath]

I think you could probably just manually remove the collaborator with that userid from the table directly and the problem will go away for you however we need to fix this so leave this bug open and PR will close it.

[witten]

Got it! I confirmed that deleting the dangling collaborator from the collaboration table fixed the problem, and I'm now able to transfer the repository successfully. I'll leave this ticket open for the PR.

Thanks for your help!