[Bug Report] Unstar private repos

[schorsch13]

Introduction

Suppose that Alice stars a repo from Bob. Bob decides to make his repo private. Alice now has 1 starred repo but is unable to view it.

Example

https://try.gitea.io/schorsch2?tab=stars

Proposal

Either remove the stars if a repo is being made private or count only public repos when displaying the amount of starred repos at the profile page

Credits

This bug was discovered by the codeberg user baobab. For further information have a look at the issue at codeberg: https://codeberg.org/Codeberg/Community/issues/480

[firephreek]

What should happen if Bob restores his repo status to Public?

• Should Alice have to re-favorite Bob's Repo or should it be automatically 're-added'?
• Should there be a notification?

[schorsch13]

Thats the thing. I think therefore it makes sense to not remove the star but decrease the counter on the profile page

[techknowlogick]

FWIW GitHub removes all stars when made private, source: https://twitter.com/github/status/1493329046708670475

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[lunny]

Looks like we can follow Github's method.