Gitea fails to complete all checks with more than 1 pattern in "Enable status check"

[makar112233]

Description

Hello.
I have a branch, which is protected with setting "Enable status check" and Build server, which is sending statuses of build in Gitea.
When I set only one pattern in a field, all checks are considered successful.
When I set multiply patterns in a filed, I got an error "Some required checks are missing"
You can see it on screenshots.

Gitea Version

1.21.7

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Multiply pattern

PR checks failed

Single patterns

PR checks successful

Git Version

latest

Operating System

linux

How are you running Gitea?

self-hosted

Database

PostgreSQL

[wxiaoguang]

Maybe there could be a workaround, for example, use these rules?

*Compile*
*Build amd64*
*Build el8*

(duplicate the Build)

Haven't tested it, but the bug seems to be caused by unmatched rules count & matched count.

---

Update:

Another question: are these patterns good enough to use?

Suppose the check rules are:

*Compile*
*Build*

there are some results:

Task1 Compile
Task2 Build
Task3 non-related

It passes the check.

Then if the results are:

Task1 Compile
Task2 Error ....
Task3 non-related Build ....

Then Task1 & Task3 make the results pass the check, but actually the Task2 should be "required".

IMO the best practice should be "clearly define the check rules", then there won't be bugs.

[makar112233]

@wxiaoguang may be I didn’t understand the question, but in the field “Status check patterns” you need to write build tasks names, not statuses.
Example:
My build server send to Gitea status of these tasks, named:

Task1 Compile
Task2 Build
Task3 non-related

and in the field “Status check patterns” I need to specify

*Compile*
*Build*

It means that if Task1 and Task2 statuses will be “OK”, I would be able to merge.
But now this rule works only for one pattern. See screenshots below.

[wxiaoguang]

I meant that in you case, there are 2 patterns to match 3 results. Could you try this one?

*Compile*
*Build amd64*
*Build el8*

Use 3 rules to match 3 results, maybe it could be a workaround.

[wxiaoguang]

The changed behavior is from #29143, because the old behavior is considered to be a "bug".

If I understand correctly, suppose there are some results:

Task1 Compile
Task2 Build amd64
Task3 Build el8

And the rules are:

*Compile*
*Build*

Before 29143, then the blow cases all pass:

Task1 Compile
Task2 Build amd64
(Task3 fails)

Task1 Compile
(Task2 fails)
Task3 Build el8

Task1 Compile
Task2 Build amd64
Task3 Build el8

---

After 29143, by using 3 rules:

*Compile*
*Build amd64*
*Build el8*

Only the result with all tasks succeeding is considered to pass.