Gitea fails to enforece all checks with "**" pattern

[splitt3r]

Description

This is related to #29628

I'm using enforced Gitea Checks for some repos. It should enforce all Jenkins Stages to pass before someone is able to merge the PR. But it doesn't work correctly.

The PR UI (Gitea Check Widget) shows all the Checks as required ("Required" labels are there). But the "Create Merge Commit" button is active anyway and can be clicked.

Using ** as a pattern to enforce alle Checks to pass does not work. If one of the Checks fails Gitea ignores that and one is able to merge the PR anyway.

Using the following pattern instead

MSBuild
Tests / QA / Unit Test / Execute Tests 
test_folder/**

does work. But once i update the Jenkins Pipeline i need to adopt the pattern in Gitea too. It would be great if the Glob pattern ** would work as intended.

Gitea Version

v1.23.8

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Ubuntu

How are you running Gitea?

Ubuntu package installation

Database

MySQL/MariaDB

[lunny]

I can't reproduce this issue on the main branch. Please verify whether the branch rule matches.

[splitt3r]

Thanks for your Feedback. I will try to reproduce it on a test instance and provide a more detailed example.

The branch rules seem to match as the Ui shows the checks as required. But the button is active anyway (see screenshot) and also after changing the pattern as described above it works as expected.

The branches are defined by glob pattern too. Sth. like {master,*/dev}.