New repo new file crash

[stuzer05]

Description

Create new repo, and click "New file" or "Upload file"

Gitea Version

1.25.0+dev-370-g4ff8cdf826

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None

[lunny]

I couldn't reproduce this.

[wxiaoguang]

Can you try to apply this patch?

diff --git a/services/context/repo.go b/services/context/repo.go
index afc6de9b16..802978ed08 100644
--- a/services/context/repo.go
+++ b/services/context/repo.go
@@ -143,7 +143,7 @@ func PrepareCommitFormOptions(ctx *Context, doer *user_model.User, targetRepo *r
        wontSignReason := ""
        if asymkey_service.IsErrWontSign(err) {
                wontSignReason = string(err.(*asymkey_service.ErrWontSign).Reason)
-       } else if err != nil {
+       } else if err != nil && !errors.Is(err, util.ErrNotExist) {
                return nil, err
        }

[stuzer05]

} else if err != nil && !errors.Is(err, util.ErrNotExist) {

Works!

[lunny]

OK. This will occur when the sign rule is set to parentsigned.

[wxiaoguang]

} else if err != nil && !errors.Is(err, util.ErrNotExist) {

Works!

I think the proper fix is like this: Skip "parentsigned" check when the repo is empty #35292. It has been merged into main branch, could you try it? Thank you.