Running a failed workflow run will immediately resend the failure email

[inxcts]

Description

Hello,

I have several Actions. Once an action fails, an email is sent.

But when I run the failed workflow again, the email is immediately sent again, although the workflow is still running and will even succeed.

Gitea Version

1.25.0+dev-473-g198f37e33c

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

macOS Tahoe

How are you running Gitea?

I downloaded the arm64 binary and this binary is running on my Mac mini.

Database

None

[NorthRealm]

Can you share your workflow file and describe what's happening?
#34982 depends on WorkflowRunStatusUpdate event (#33964), which was a bit of fragile and led to #35215. So if it's duplicating, we have to audit how the events are triggered once again 🤦
And I don't have enough time debugging this Gitea stuff these days.

[inxcts]

This is my workflow:

name: 'Create App Version'
on:
  push:
    tags:
      - '[0-9]+.[0-9]+.[0-9]+'

jobs:
  Create:
    runs-on: mac
    name: 'Create Version'
    steps:
      - name: Create Version
        uses: http://home-server:3000/inexcitus/create-app-version@main
        with:
          id: 123456789
          version: ${{ github.ref_name }}

  Notes:
    runs-on: mac
    needs: Create
    steps:
      - name: Set Release Notes
        uses: http://home-server:3000/inexcitus/set-release-notes@main
        with:
          id: 123456789
          version: ${{ github.ref_name }}

  Upload:
    runs-on: development
    steps:
      - uses: actions/checkout@v4
      
      - name: Create Archive
        uses:  http://home-server:3000/inexcitus/archive-app@main
        with:
          scheme: Scheme
          archive: Archive-Name
          version: ${{ github.ref_name }}

This workflow is triggered whenever I create a tag. it will then create a new version in App Store Connect, set a release note and archives my app and then uploads it to App Store Connect.

The last step can sometimes fail when something went wrong with the upload process. The email is then sent because the workflow run has failed, which is fine.

However, if I restart the failed run, the email is sent again but the workflow run ultimately succeeds this time.

This is not specific to this run, it happens with every run. You can reproduce this quite easily by compiling an app that will fail. Simply restart the run and the mail is sent again (the run will fail again, but this should not matter, it's just for demonstration purposes).

[badhezi]

unfortunately the check in

gitea/services/mailer/mail_workflow_run.go

Line 45 in c453210

if !job.Status.IsDone() {

is not effective

I see that we trigger a notify both on job initial trigger and at the end, but the job status updates only occurs between these two triggers so any job status check will just show the last stored value (before the run is executed), which will fail the !IsDone() check and trigger the email send anyway

I can try to address this issue.