Incomplete diff highlighting (only the first line of a block?)

[PiOverFour]

Description

In a diff for a PR, the highlighting is off: not every addition or deletion is highlighted. It looks like in a given block, only the first line is compared, even when using the option to ignore changes to EOL whitespace.

Example: https://projects.blender.org/blender/blender/pulls/147347/files
Also on Gitea demo: https://demo.gitea.com/pioverfour/test_diff/commit/a64d3749dc037591358b69cfc5eaddb19aa7cea8

Gitea	Expected (from the magit git client)

Gitea Version

1.24.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I can reproduce this using demo.gitea.com.

Database

None

[wxiaoguang]

I think the reason is that it doesn't extremely highlight all newly added lines.

Take a general case as example:

Old:

part1 part2 part3

New:

part1
part2
part3

The line-by-line diff is:

- part1 part2 part3
+ part1
+ part2
+ part3

The part2 and part3 are considered as "newly added lines", so they already have a green background, and don't get extra highlights.

TBH IMO "magit git client"'s result seems more inconsistency and doesn't read better.

[PiOverFour]

TBH IMO "magit git client"'s result seems more inconsistency and doesn't read better.

I disagree but I can’t really argue with that, it’s a matter of personal preference. My point is, when ignoring whitespace I think it makes more sense to also ignore changes in newlines — but that’s also personal preference of course.

[wxiaoguang]

Yep, that's arguable .... 😄

My point is, when ignoring whitespace I think it makes more sense to also ignore changes in newlines

Hmm ... IMO ignoring spaces doesn't mean ignoring new lines.

Anyway, maybe there can be some algorithms to handle these cases and generate the results you prefer, but I have no idea at the moment. 🤷

[PiOverFour]

I see, thanks for you reply!