Commit/Editor diff preview for .sql files does not handle multiple line highlighting correctly

[JpMand]

Description

When viewing the Diff of a .sql file (either from commit or PR ) some lines of the script that contains actual sql code (instead of comment) are highlighted as comment and sometimes also renders comments as actual code

Behavior of the render differs between the normal diff, the expanded diff code and the preview diff during edit from web (multiline comment is rendered different between commit diff and preview diff)

It could be a leftover from #33358

I am able to reproduce in the Gitea demo instance.
Repository used for testing: https://demo.gitea.com/JpMand/idea-plugin-demo-repo

Gitea Version

1.25.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

I'm using https://demo.gitea.com

Database

None

[silverwind]

Is this an issue in regular diff views (commit or pr, not expanded) or only those two "special" diffs?

1. Expanded diff sections having odd highlighting was noticed in Expanded diff sections have odd syntax highlighing #35252 as well.
2. For the web editor preview, we should check if it does actual full-file highlighting. I could imagine that that part was missed in Syntax highlighting should be full-file only #33358.

[JpMand]

Is this an issue in regular diff views (commit or pr, not expanded) or only those two "special" diffs?

It's an issue for both regular diff views and the special diffs.
The difference is that some render errors, that appear in the expanded and editor preview diffs, do not appear in the regular (like the multiline comment as it behaves correctly for the regular diff while incorrectly for the preview).

Question: I've used the wrong template to make this issue (since it should be a UI issue). Should I close this one and remake it or should I simply add the relevant information requested (like the browser version)?

[silverwind]

No it's fine. I see the problematic highlight in this regular view:

https://demo.gitea.com/JpMand/idea-plugin-demo-repo/commit/4c89f0afcdf0634d29af0b6b38dbd1128e80ec4f

[wxiaoguang]

Fixed:

• Commit diff: Full-file syntax highlighting for diff pages Full-file syntax highlighting for diff pages #33766

Remaining:

• Editor's preview (this issue's report)
• Commit diff expanding (Expanded diff sections have odd syntax highlighing #35252)

[JpMand]

Fixed:

* Commit diff:  Full-file syntax highlighting for diff pages

Question: the https://demo.gitea.com/ version 1.26.0+dev-146-g1da1e644ed includes the PR #33766 mentioned?

I'm asking because the regular commit diff highlight problem is reproducible in https://demo.gitea.com/ version 1.26.0+dev-146-g1da1e644ed

[wxiaoguang]

Fixed:

* Commit diff:  Full-file syntax highlighting for diff pages

Question: the https://demo.gitea.com/ version 1.26.0+dev-146-g1da1e644ed includes the PR #33766 mentioned?

I'm asking because the regular diff highlight problem is reproducible in https://demo.gitea.com/ version 1.26.0+dev-146-g1da1e644ed

#33766 is included in Gitea 1.24 and later. I did a quick test, hmm .... yes, the result doesn't seem right.

---

Your issue's screenshot: it is the editor's preview diff

[JpMand]

Can someone add the label topic/ui?
I've mistakenly not used the correct template (used the generic Bug Report instead of Web Interface Bug Report), so it did not include the label.