Skip to content

Fix panic when cloning with wrong ssh format. #32076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Fix panic when cloning with wrong ssh format. #32076

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df12cc1
Fix ssh clone with error format
lunny Sep 19, 2024
1991874
Add recover to prevent more panic detail
lunny Sep 19, 2024
7261a27
Fix lint
lunny Sep 19, 2024
6a853d8
Merge branch 'main' into lunny/fix_clone
lunny Sep 19, 2024
58fdadd
Don't ignore panic log
lunny Sep 20, 2024
d268149
Merge branch 'main' into lunny/fix_clone
lunny Sep 20, 2024
2225fb5
Merge branch 'main' into lunny/fix_clone
lunny Sep 24, 2024
7c33830
Merge branch 'main' into lunny/fix_clone
GiteaBot Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cmd/serv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ func runServ(c *cli.Context) error {
return nil
}

defer func() {
if err := recover(); err != nil {
_ = fail(ctx, "Internal Server Error", "Panic: %v\n%s", err, log.Stack(2))
}
}()

keys := strings.Split(c.Args().First(), "-")
if len(keys) != 2 || keys[0] != "key" {
return fail(ctx, "Key ID format error", "Invalid key argument: %s", c.Args().First())
Expand Down Expand Up @@ -189,10 +195,7 @@ func runServ(c *cli.Context) error {
}

verb := words[0]
repoPath := words[1]
if repoPath[0] == '/' {
repoPath = repoPath[1:]
}
repoPath := strings.TrimPrefix(words[1], "/")

var lfsVerb string
if verb == lfsAuthenticateVerb {
Expand Down
Loading