Refactor sidebar label selector #32460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
wxiaoguang
added
the
type/refactoring
wxiaoguang
force-pushed
the
fix-sidebar
branch
2 times, most recently
from
6a72183 to
da40151
Compare
wxiaoguang
force-pushed
the
fix-sidebar
branch
from
da40151 to
0169fd3
Compare
lunny
approved these changes
Nov 10, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
fix-sidebar
branch
from
0f1a412 to
ac9241b
Compare
wolfogre
approved these changes
Nov 10, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 10, 2024
* giteaofficial/main: Refactor sidebar label selector (go-gitea#32460) Fix mermaid diagram height when initially hidden (go-gitea#32457) Add reviewers selection to new pull request (go-gitea#32403) Fix issue sidebar (go-gitea#32455) Refactor language menu and dom utils (go-gitea#32450) Fix broken releases when re-pushing tags (go-gitea#32435) Refactor issue page info (go-gitea#32445) Split issue sidebar into small templates (go-gitea#32444) Only provide the commit summary for Discord webhook push events (go-gitea#32432) Add new event commit status creation and webhook implementation (go-gitea#27151) Support quote selected comments to reply (go-gitea#32431) Move AddCollabrator and CreateRepositoryByExample to service layer (go-gitea#32419) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
lunny
pushed a commit
that referenced
this pull request
Nov 10, 2024
Follow #32460 Now the code could be much clearer than before and easier to maintain. A lot of legacy code is removed. Manually tested. This PR is large enough, that fine tunes could be deferred to the future if there is no bug found or design problem. Screenshots: <details>  </details>
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Nov 20, 2024
…rolling as title, replace go-gitea#31597 after go-gitea#32460 Signed-off-by: a1012112796 <[email protected]>
wxiaoguang
pushed a commit
that referenced
this pull request
Nov 21, 2024
…ling (#32576) as title, replace #31597 after #32460 --------- Signed-off-by: a1012112796 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
issueSidebarLabelsDatato handle all sidebar labels related data.Tested:
Issue Template
New Issue
New PR
Edit Labels (with Archived)
Scoped