- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
Reimplement GetUserOrgsList to make it simple and clear #32486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          
      
        
          +205
        
        
          −172
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    d2554f2    to
    1a152ad      
    Compare
  
    
              
                    Zettat123
  
              
              approved these changes
              
                  
                    Nov 14, 2024 
                  
              
              
            
            
Co-authored-by: Zettat123 <[email protected]>
              
                    wxiaoguang
  
              
              reviewed
              
                  
                    Nov 14, 2024 
                  
              
              
            
            
…itea into lunny/reimplement_GetUserOrgsLit
              
                    wxiaoguang
  
              
              approved these changes
              
                  
                    Nov 14, 2024 
                  
              
              
            
            
    
  zjjhot 
      added a commit
        to zjjhot/gitea
      that referenced
      this pull request
    
      Nov 15, 2024 
    
    
      
  
    
      
    
  
* giteaofficial/main: Fix oauth2 error handle not return immediately (go-gitea#32514) Fix incorrect project page CSS class (go-gitea#32510) Add avif image file support (go-gitea#32508) Reduce integration test overhead (go-gitea#32475) Remove jQuery import from some files (go-gitea#32512) Trim title before insert/update to database to match the size requirements of database (go-gitea#32498) Reimplement GetUserOrgsList to make it simple and clear (go-gitea#32486)
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    lgtm/done
  This PR has enough approvals to get merged. There are no important open reservations anymore. 
  
    modifies/go
  Pull requests that update Go code 
  
    type/refactoring
  Existing code has been cleaned up. There should be no new functionality. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Reimplement GetUserOrgsList and also move some functions and test to org_list file.