Skip to content

Move GetFeeds to service layer #32526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 29, 2024
Merged

Move GetFeeds to service layer #32526

merged 10 commits into from
Nov 29, 2024

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 15, 2024 •
edited
Loading

Move GetFeeds from models to service layer, no code change.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 15, 2024
@lunny lunny force-pushed the lunny/refactor_feed branch from 09288c1 to c44c754 Compare November 15, 2024 18:22
@lunny lunny force-pushed the lunny/refactor_feed branch from c44c754 to 4aae792 Compare November 16, 2024 19:41
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 29, 2024
@lunny lunny enabled auto-merge (squash) November 29, 2024 17:28
@lunny lunny merged commit 1ed5f37 into go-gitea:main Nov 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 29, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 29, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
24e46aa 
* giteaofficial/main:
  Split mail sender sub package from mailer service package (go-gitea#32618)
  Fix a bug in actions artifact test (go-gitea#32672)
  Move GetFeeds to service layer (go-gitea#32526)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 27, 2025
@lunny lunny deleted the lunny/refactor_feed branch March 26, 2025 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wolfogre @delvh @GiteaBot