Skip to content

Fix line-button issue after file selection in file tree #34574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

Fix line-button issue after file selection in file tree #34574

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad277ed
Fix line-button issue after file selection in file tree
kerwin612 Jun 1, 2025
25f2da7
fix
wxiaoguang Jun 1, 2025
48bd59a
fix tippy temp tooltip position
wxiaoguang Jun 1, 2025
3e23e49
fine tune comments
wxiaoguang Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/view_file.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
{{end}}
</div>
{{else if .FileSize}}
<table>
<table data-global-init="initRepoCodeView">
<tbody>
{{range $idx, $code := .FileContent}}
{{$line := Eval $idx "+" 1}}
Expand Down
29 changes: 16 additions & 13 deletions web_src/js/features/repo-code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {svg} from '../svg.ts';
import {createTippy} from '../modules/tippy.ts';
import {toAbsoluteUrl} from '../utils.ts';
import {addDelegatedEventListener} from '../utils/dom.ts';
import {registerGlobalInitFunc} from '../modules/observer.ts';

function changeHash(hash: string) {
if (window.history.pushState) {
Expand Down Expand Up @@ -110,19 +111,21 @@ function showLineButton() {
}

export function initRepoCodeView() {
if (!document.querySelector('.code-view .lines-num')) return;

let selRangeStart: string;
addDelegatedEventListener(document, 'click', '.lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
if (!selRangeStart || !e.shiftKey) {
selRangeStart = el.getAttribute('id');
selectRange(selRangeStart);
} else {
const selRangeStop = el.getAttribute('id');
selectRange(`${selRangeStart}-${selRangeStop}`);
}
window.getSelection().removeAllRanges();
showLineButton();
registerGlobalInitFunc('initRepoCodeView', (el: HTMLElement) => {
if (!el.querySelector('.lines-num')) return;

let selRangeStart: string;
addDelegatedEventListener(el, 'click', '.lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
if (!selRangeStart || !e.shiftKey) {
selRangeStart = el.getAttribute('id');
selectRange(selRangeStart);
} else {
const selRangeStop = el.getAttribute('id');
selectRange(`${selRangeStart}-${selRangeStop}`);
}
window.getSelection().removeAllRanges();
showLineButton();
});
});

const onHashChange = () => {
Expand Down