Fix modal + form abuse #34921
Merged
Fix modal + form abuse #34921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
Tested the related changes:
|
lunny
approved these changes
Jul 1, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jul 1, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2025
* giteaofficial/main: Fix modal + form abuse (go-gitea#34921) [skip ci] Updated translations via Crowdin Follow file symlinks in the UI to their target (go-gitea#28835) Fix issue filter (go-gitea#34914) Fix: RPM package download routing & missing package version count (go-gitea#34909) Add support for 3D/CAD file formats preview (go-gitea#34794)
delvh
reviewed
Jul 1, 2025
| window.location.href = data.redirect; | ||
| } | ||
| (async () => { | ||
| const response = await POST(btn.getAttribute('data-url'), {data: postData}); |
There was a problem hiding this comment.
Isn't there a modal.classList.remove('is-loading') missing?
There was a problem hiding this comment.
I think no because :
- when the request succeeds, the page gets reloaded
- when the request fails, there is no message feedback, so we can't make the form re-submit.
- this part of code is for the legacy "delete-button", there are already many problems in it, so I think no need to do more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment. And due to the abuse, there is a regression: when the modal is hidden, the form will be reset and it can't submit.
This PR fixes all problems: keep the modal with form open, and add "loading" indicator.