Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jul 9, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jul 9, 2025
@wxiaoguang
Copy link
Contributor

I don't think it is well-designed and don't see why it is a must.

Please correct me if I was wrong: #34823 (comment)

@lunny
Copy link
Member Author

lunny commented Jul 10, 2025

I don't think it is well-designed and don't see why it is a must.

Please correct me if I was wrong: #34823 (comment)

There is a bug there. The job cannot be cancelled when it's running with failure because the aggregated status is failure not running. ref #35000 (comment)

@wxiaoguang
Copy link
Contributor

Then it needs to detect the "cancel-able" basing on non-aggregated status?

@lunny
Copy link
Member Author

lunny commented Jul 10, 2025

Then it needs to detect the "cancel-able" basing on non-aggregated status?

However, it would still be strange if a failed task could be cancelled.

Alternatively, we could consider merging #35000. The waiting status, similar to running, should have higher priority than failure during aggregation.

@wxiaoguang
Copy link
Contributor

Alternatively, we could consider merging #35000. The waiting status, similar to running, should have higher priority than failure during aggregation.

I think I have explained in #34823 (comment), job status and commit status indeed should have different state priorities.

correct me if I was wrong

@lunny
Copy link
Member Author

lunny commented Jul 10, 2025

Alternatively, we could consider merging #35000. The waiting status, similar to running, should have higher priority than failure during aggregation.

I think I have explained in #34823 (comment), job status and commit status indeed should have different state priorities.

correct me if I was wrong

#35000 is just for job status not for commit status.

@wxiaoguang
Copy link
Contributor

Alternatively, we could consider merging #35000. The waiting status, similar to running, should have higher priority than failure during aggregation.

I think I have explained in #34823 (comment), job status and commit status indeed should have different state priorities.
correct me if I was wrong

#35000 is just for job status not for commit status.

Yes it is, so what's the problem?

@lunny lunny closed this Jul 17, 2025
@lunny lunny deleted the lunny/add_running_with_failure_status branch July 17, 2025 21:28
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants