Update job status on rerun - avoid duplicate email notification #35575
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
badhezi
changed the title
wxiaoguang
reviewed
Oct 3, 2025
badhezi
force-pushed
the
hezi/update-run-status-on-rerun
branch
from
56dab26 to
5486690
Compare
|
@ChristopherHX I took a simpler approach by checking if the workflow has just been rerun in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #35556
When triggering a job re-run, we send a duplicate email notification in case the previous state of the job (prior to the re-run), required an email notification.
This change just sets the job status to
waitingbefore all the notifiers evaluation so it will only notify at the end of the job run with the updated status.