fix: Allow escaped double quotes in struct tag parser (#7631)

* fix: support escaping double quotes in struct tag parser

* chore: resolve lint errors in util_test.go

Author: kankankanp

schema/utils.go

@@ -17,25 +17,23 @@ func ParseTagSetting(str string, sep string) map[string]string {
 	settings := map[string]string{}
 	names := strings.Split(str, sep)
 
+	var parsedNames []string
 	for i := 0; i < len(names); i++ {
-		j := i
-		if len(names[j]) > 0 {
-			for {
-				if names[j][len(names[j])-1] == '\\' {
-					i++
-					names[j] = names[j][0:len(names[j])-1] + sep + names[i]
-					names[i] = ""
-				} else {
-					break
-				}
-			}
+		s := names[i]
+		for strings.HasSuffix(s, "\\") && i+1 < len(names) {
+			i++
+			s = s[:len(s)-1] + sep + names[i]
 		}
+		parsedNames = append(parsedNames, s)
+	}
 
-		values := strings.Split(names[j], ":")
+	for _, tag := range parsedNames {
+		values := strings.Split(tag, ":")
 		k := strings.TrimSpace(strings.ToUpper(values[0]))
-
 		if len(values) >= 2 {
-			settings[k] = strings.Join(values[1:], ":")
+			val := strings.Join(values[1:], ":")
+			val = strings.ReplaceAll(val, `\"`, `"`)
+			settings[k] = val
 		} else if k != "" {
 			settings[k] = k
 		}

schema/utils_test.go

@@ -22,3 +22,11 @@ func TestRemoveSettingFromTag(t *testing.T) {
 		}
 	}
 }
+
+func TestParseTagSettingWithDoubleQuoteEscape(t *testing.T) {
+	tag := `gorm:"expression:to_tsvector('english', \"Name\")"`
+	settings := ParseTagSetting(reflect.StructTag(tag).Get("gorm"), ";")
+	if v, ok := settings["EXPRESSION"]; !ok || v != `to_tsvector('english', "Name")` {
+		t.Errorf("ParseTagSetting did not handle escaped double quotes correctly: got %#v", v)
+	}
+}