allow additional metric configuration in ReportDBStatsMetrics (#33)

steved · web-flow · commit 68c1f9a7b560 · 2024-11-24T09:13:57.000+08:00
diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -33,15 +33,15 @@ func newConfig() *config {
 }
 
 // ReportDBStatsMetrics reports DBStats metrics using OpenTelemetry Metrics API.
-func ReportDBStatsMetrics(db *sql.DB) {
+func ReportDBStatsMetrics(db *sql.DB, opts ...metric.ObserveOption) {
 	cfg := newConfig()
 
 	if cfg.meter == nil {
 		cfg.meter = cfg.meterProvider.Meter(instrumName)
 	}
 
 	meter := cfg.meter
-	opts := cfg.opts
+	opts = append(cfg.opts, opts...)
 
 	maxOpenConns, _ := meter.Int64ObservableGauge(
 		"go.sql.connections_max_open",

Original file line number	Diff line number	Diff line change
`@@ -33,15 +33,15 @@ func newConfig() *config {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`// ReportDBStatsMetrics reports DBStats metrics using OpenTelemetry Metrics API.`
`36`		`-func ReportDBStatsMetrics(db *sql.DB) {`
	`36`	`+func ReportDBStatsMetrics(db *sql.DB, opts ...metric.ObserveOption) {`
`37`	`37`	`cfg := newConfig()`
`38`	`38`
`39`	`39`	`if cfg.meter == nil {`
`40`	`40`	`cfg.meter = cfg.meterProvider.Meter(instrumName)`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`meter := cfg.meter`
`44`		`- opts := cfg.opts`
	`44`	`+ opts = append(cfg.opts, opts...)`
`45`	`45`
`46`	`46`	`maxOpenConns, _ := meter.Int64ObservableGauge(`
`47`	`47`	`"go.sql.connections_max_open",`