wasm: fix infinite recursion in DuplicateExportError

laizy · sbinet · commit 0864b865364c · 2019-07-30T09:42:56.000+02:00
diff --git a/wasm/module_test.go b/wasm/module_test.go
@@ -168,3 +168,8 @@ func TestModuleSignatureCheck(t *testing.T) {
 		})
 	}
 }
+
+func TestDuplicateExportError_NoStackOverflow(t *testing.T) {
+	err := wasm.DuplicateExportError("h")
+	_ = err.Error()
+}
diff --git a/wasm/section.go b/wasm/section.go
@@ -633,7 +633,7 @@ func (s *SectionExports) WritePayload(w io.Writer) error {
 type DuplicateExportError string
 
 func (e DuplicateExportError) Error() string {
-	return fmt.Sprintf("Duplicate export entry: %s", e)
+	return fmt.Sprintf("Duplicate export entry: %s", string(e))
 }
 
 // ExportEntry represents an exported entry by the module

Original file line number	Diff line number	Diff line change
`@@ -168,3 +168,8 @@ func TestModuleSignatureCheck(t *testing.T) {`
`168`	`168`	`})`
`169`	`169`	`}`
`170`	`170`	`}`
	`171`	`+`
	`172`	`+func TestDuplicateExportError_NoStackOverflow(t *testing.T) {`
	`173`	`+ err := wasm.DuplicateExportError("h")`
	`174`	`+ _ = err.Error()`
	`175`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ func (s *SectionExports) WritePayload(w io.Writer) error {`
`633`	`633`	`type DuplicateExportError string`
`634`	`634`
`635`	`635`	`func (e DuplicateExportError) Error() string {`
`636`		`- return fmt.Sprintf("Duplicate export entry: %s", e)`
	`636`	`+ return fmt.Sprintf("Duplicate export entry: %s", string(e))`
`637`	`637`	`}`
`638`	`638`
`639`	`639`	`// ExportEntry represents an exported entry by the module`