fix: returns wrong error in transaction (#45)

lonetrail · web-flow · commit 3a46aa32f7db · 2024-09-06T10:31:35.000+08:00
diff --git a/transaction/ent/internal/biz/transaction.go b/transaction/ent/internal/biz/transaction.go
@@ -34,16 +34,17 @@ func (u *UserUsecase) CreateUser(ctx context.Context, m *User) (int, error) {
 		err error
 		id  int
 	)
-	if e := u.tm.InTx(ctx, func(ctx context.Context) error {
+	err = u.tm.InTx(ctx, func(ctx context.Context) error {
 		id, err = u.userRepo.CreateUser(ctx, m)
 		if err != nil {
 			return err
 		}
-		if _, e := u.cardRepo.CreateCard(ctx, id); err != nil {
-			return e
+		if _, err := u.cardRepo.CreateCard(ctx, id); err != nil {
+			return err
 		}
 		return nil
-	}); e != nil {
+	})
+	if err != nil {
 		return 0, err
 	}
 	return id, nil

Original file line number	Diff line number	Diff line change
`@@ -34,16 +34,17 @@ func (u UserUsecase) CreateUser(ctx context.Context, m User) (int, error) {`
`34`	`34`	`err error`
`35`	`35`	`id int`
`36`	`36`	`)`
`37`		`- if e := u.tm.InTx(ctx, func(ctx context.Context) error {`
	`37`	`+ err = u.tm.InTx(ctx, func(ctx context.Context) error {`
`38`	`38`	`id, err = u.userRepo.CreateUser(ctx, m)`
`39`	`39`	`if err != nil {`
`40`	`40`	`return err`
`41`	`41`	`}`
`42`		`- if _, e := u.cardRepo.CreateCard(ctx, id); err != nil {`
`43`		`- return e`
	`42`	`+ if _, err := u.cardRepo.CreateCard(ctx, id); err != nil {`
	`43`	`+ return err`
`44`	`44`	`}`
`45`	`45`	`return nil`
`46`		`- }); e != nil {`
	`46`	`+ })`
	`47`	`+ if err != nil {`
`47`	`48`	`return 0, err`
`48`	`49`	`}`
`49`	`50`	`return id, nil`