jsonrpc2: fix 'call to (*T).Fatalf from a non-test goroutine' vet error

zchee · zchee · commit 8df42f4d44c9 · 2020-02-02T20:53:15.000+09:00
diff --git a/jsonrpc2_test.go b/jsonrpc2_test.go
@@ -84,10 +84,14 @@ func run(ctx context.Context, t *testing.T, r io.ReadCloser, w io.WriteCloser) *
 		}()
 
 		if err := conn.Run(ctx); err != nil {
-			t.Fatalf("Stream failed: %v", err)
+			t.Errorf("Stream failed: %v", err)
 		}
 	}()
 
+	if t.Failed() {
+		t.FailNow()
+	}
+
 	return conn
 }
 

Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,14 @@ func run(ctx context.Context, t testing.T, r io.ReadCloser, w io.WriteCloser) `
`84`	`84`	`}()`
`85`	`85`
`86`	`86`	`if err := conn.Run(ctx); err != nil {`
`87`		`- t.Fatalf("Stream failed: %v", err)`
	`87`	`+ t.Errorf("Stream failed: %v", err)`
`88`	`88`	`}`
`89`	`89`	`}()`
`90`	`90`
	`91`	`+ if t.Failed() {`
	`92`	`+ t.FailNow()`
	`93`	`+ }`
	`94`	`+`
`91`	`95`	`return conn`
`92`	`96`	`}`
`93`	`97`