all: fix lint issues

Signed-off-by: Koichi Shiraishi <[email protected]>

Author: zchee

.golangci.yml

@@ -31,10 +31,8 @@ linters:
     - cyclop                    # checks function and package cyclomatic complexity
     - decorder                  # check declaration order and count of types, constants, variables and functions
     - dogsled                   # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
-    - dupl                      # Tool for code clone detection
     - dupword                   # checks for duplicate words in the source code
     - durationcheck             # check for two durations multiplied together
-    - errcheck                  # errcheck is a program for checking for unchecked errors in Go code. These unchecked errors can be critical bugs in some cases
     - errchkjson                # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occasions, where the check for the returned error can be omitted.
     - errname                   # Checks that sentinel errors are prefixed with the `Err` and error types are suffixed with the `Error`.
     - errorlint                 # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
@@ -44,7 +42,6 @@ linters:
     - ginkgolinter              # enforces standards of using ginkgo and gomega
     - gocheckcompilerdirectives # Checks that go compiler directive comments (//go:) are valid
     - gocognit                  # Computes and checks the cognitive complexity of functions
-    - goconst                   # Finds repeated strings that could be replaced by a constant
     - gocritic                  # Provides diagnostics that check for bugs, performance and style issues.
     - gocyclo                   # Computes and checks the cyclomatic complexity of functions
     - godot                     # Check if comments end in a period
@@ -61,9 +58,7 @@ linters:
     - importas                  # Enforces consistent import aliases
     - inamedparam               # reports interfaces with unnamed method parameters [fast: true, auto-fix: false]
     - ineffassign               # Detects when assignments to existing variables are not used
-    - interfacebloat            # A linter that checks the number of methods inside an interface
     - intrange                  # intrange is a linter to find places where for loops could make use of an integer range. [fast: true, auto-fix: false]
-    - lll                       # Reports long lines
     - loggercheck               # Checks key value pairs for common logger libraries (kitlog,klog,logr,zap).
     - maintidx                  # maintidx measures the maintainability index of each function.
     - makezero                  # Finds slice declarations with non-zero initial length
@@ -94,15 +89,13 @@ linters:
     - tenv                      # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17
     - testableexamples          # linter checks if examples are testable (have an expected output)
     - thelper                   # thelper detects Go test helpers without t.Helper() call and checks the consistency of test helpers
-    - tparallel                 # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes
     - unconvert                 # Remove unnecessary type conversions
     - unparam                   # Reports unused function parameters
     - unused                    # Checks Go code for unused constants, variables, functions and types
     - usestdlibvars             # A linter that detect the possibility to use variables/constants from the Go standard library
     - varnamelen                # checks that the length of a variable's name matches its scope
     - wastedassign              # wastedassign finds wasted assignment statements.
     - whitespace                # Tool for detection of leading and trailing whitespace
-    - wrapcheck                 # Checks that errors returned from external packages are wrapped
     - zerologlint               # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]
 
 linters-settings:
@@ -114,15 +107,6 @@ linters-settings:
     max-complexity: 15
     # package-average:
     skip-tests: true
-  dupl:
-    threshold: 150
-  errcheck:
-    disable-default-exclusions: false
-    check-type-assertions: false
-    check-blank: true
-    ignore: ""
-    # exclude: .errcheckignore
-    exclude-functions: []
   errorlint:
     errorf: true
     asserts: true
@@ -132,9 +116,6 @@ linters-settings:
     statements: 60
   gocognit:
     min-complexity: 30
-  goconst:
-    min-len: 3
-    min-occurrences: 3
   gocritic:
     enabled-tags:
       - diagnostic
@@ -144,6 +125,7 @@ linters-settings:
       - style
     disabled-checks:
       - commentedOutCode
+      - deprecatedComment
       - whyNoLint
     settings:
       hugeParam:
@@ -177,6 +159,9 @@ linters-settings:
     under: 15
   misspell:
     locale: US
+    ignore-words:
+      - cancelled
+      - cancelling
   nakedret:
     max-func-lines: 30
   nestif:
@@ -204,7 +189,6 @@ linters-settings:
 issues:
   include:
     # include revive rules
-    - "EXC0012"
     - "EXC0013"
     - "EXC0014"
     - "EXC0015"

base.go

@@ -73,7 +73,7 @@ func (v ProgressToken) Format(f fmt.State, r rune) {
 
 // String returns a string representation of the ProgressToken.
 func (v ProgressToken) String() string {
-	return fmt.Sprint(v)
+	return fmt.Sprint(v) //nolint:gocritic
 }
 
 // MarshalJSON implements json.Marshaler.

base_test.go

@@ -4,7 +4,6 @@
 package protocol
 
 import (
-	"fmt"
 	"reflect"
 	"testing"
 
@@ -176,7 +175,7 @@ func TestProgressParams(t *testing.T) {
 				}
 
 				if token := got.Token; !reflect.ValueOf(token).IsZero() {
-					if diff := cmp.Diff(fmt.Sprint(token), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(token.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}

basic.go

@@ -93,7 +93,7 @@ type LocationLink struct {
 	// TargetSelectionRange is the range that should be selected and revealed when this link is being followed,
 	// e.g the name of a function.
 	//
-	// Must be contained by the the TargetRange. See also DocumentSymbol#range
+	// Must be contained by the TargetRange. See also DocumentSymbol#range
 	TargetSelectionRange Range `json:"targetSelectionRange"`
 }
 
@@ -346,7 +346,7 @@ const (
 	// ClojureLanguage Clojure Language.
 	ClojureLanguage LanguageIdentifier = "clojure"
 
-	// CoffeescriptLanguage CoffeeScript Language.
+	// CoffeeScriptLanguage CoffeeScript Language.
 	CoffeeScriptLanguage LanguageIdentifier = "coffeescript"
 
 	// CLanguage C Language.

callhierarchy_test.go

@@ -4,7 +4,6 @@
 package protocol
 
 import (
-	"fmt"
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
@@ -506,7 +505,7 @@ func TestCallHierarchyPrepareParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -852,13 +851,13 @@ func TestCallHierarchyIncomingCallsParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -1178,13 +1177,13 @@ func TestCallHierarchyOutgoingCallsParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}

errors.go

@@ -13,12 +13,12 @@ const (
 	// @since 3.16.0.
 	LSPReservedErrorRangeStart jsonrpc2.Code = -32899
 
-	// ContentModified is the state change that invalidates the result of a request in execution.
+	// CodeContentModified is the state change that invalidates the result of a request in execution.
 	//
 	// Defined by the protocol.
 	CodeContentModified jsonrpc2.Code = -32801
 
-	// RequestCancelled is the cancellation error.
+	// CodeRequestCancelled is the cancellation error.
 	//
 	// Defined by the protocol.
 	CodeRequestCancelled jsonrpc2.Code = -32800

general_test.go

@@ -4,7 +4,6 @@
 package protocol
 
 import (
-	"fmt"
 	"path/filepath"
 	"testing"
 
@@ -329,7 +328,7 @@ func TestInitializeParams(t *testing.T) {
 				}
 
 				if token := got.WorkDoneToken; token != nil {
-					if diff := cmp.Diff(fmt.Sprint(token), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(token.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -990,13 +989,13 @@ func TestReferencesParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -1259,13 +1258,13 @@ func TestDocumentHighlightParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -2129,13 +2128,13 @@ func TestDeclarationParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -2398,13 +2397,13 @@ func TestDefinitionParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -2807,13 +2806,13 @@ func TestTypeDefinitionParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
@@ -3202,13 +3201,13 @@ func TestImplementationParams(t *testing.T) {
 				}
 
 				if workDoneToken := got.WorkDoneToken; workDoneToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(workDoneToken), wantWorkDoneToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(workDoneToken.String(), wantWorkDoneToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}
 
 				if partialResultToken := got.PartialResultToken; partialResultToken != nil {
-					if diff := cmp.Diff(fmt.Sprint(partialResultToken), wantPartialResultToken); (diff != "") != tt.wantErr {
+					if diff := cmp.Diff(partialResultToken.String(), wantPartialResultToken); (diff != "") != tt.wantErr {
 						t.Errorf("%s: wantErr: %t\n(-want +got)\n%s", tt.name, tt.wantErr, diff)
 					}
 				}

handler.go

@@ -84,5 +84,5 @@ func notifyCancel(ctx context.Context, conn jsonrpc2.Conn, id jsonrpc2.ID) {
 }
 
 func replyParseError(ctx context.Context, reply jsonrpc2.Replier, err error) error {
-	return reply(ctx, nil, fmt.Errorf("%s: %w", jsonrpc2.ErrParse, err))
+	return reply(ctx, nil, fmt.Errorf("%w: %w", jsonrpc2.ErrParse, err))
 }

language.go

@@ -119,14 +119,14 @@ type InsertReplaceEdit struct {
 type InsertTextMode float64
 
 const (
-	// AsIs is the insertion or replace strings is taken as it is. If the
+	// InsertTextModeAsIs is the insertion or replace strings is taken as it is. If the
 	// value is multi line the lines below the cursor will be
 	// inserted using the indentation defined in the string value.
 	// The client will not apply any kind of adjustments to the
 	// string.
 	InsertTextModeAsIs InsertTextMode = 1
 
-	// AdjustIndentation is the editor adjusts leading whitespace of new lines so that
+	// InsertTextModeAdjustIndentation is the editor adjusts leading whitespace of new lines so that
 	// they match the indentation up to the cursor of the line for
 	// which the item is accepted.
 	//