Rework individual methods for INSERT/UPDATE/DELETE into a single public RowsEvent type.

Author: proton-lisandro-pin

replication/row_event.go

@@ -950,6 +950,29 @@ type RowsEvent struct {
 	ignoreJSONDecodeErr     bool
 }
 
+// EnumRowsEventType is an abridged type describing the operation which triggered the given RowsEvent.
+type EnumRowsEventType byte
+
+const (
+	EnumRowsEventTypeUnknown = EnumRowsEventType(iota)
+	EnumRowsEventTypeInsert
+	EnumRowsEventTypeUpdate
+	EnumRowsEventTypeDelete
+)
+
+func (t EnumRowsEventType) String() string {
+	switch t {
+	case EnumRowsEventTypeInsert:
+		return "Insert"
+	case EnumRowsEventTypeUpdate:
+		return "Update"
+	case EnumRowsEventTypeDelete:
+		return "Delete"
+	default:
+		return fmt.Sprintf("unknown (%d)", t)
+	}
+}
+
 // EnumRowImageType is allowed types for every row in mysql binlog.
 // See https://github.com/mysql/mysql-server/blob/1bfe02bdad6604d54913c62614bde57a055c8332/sql/rpl_record.h#L39
 // enum class enum_row_image_type { WRITE_AI, UPDATE_BI, UPDATE_AI, DELETE_BI };
@@ -1120,16 +1143,17 @@ func (e *RowsEvent) Decode(data []byte) error {
 	return e.DecodeData(pos, data)
 }
 
-func (e *RowsEvent) IsInsert() bool {
-	return e.eventType == WRITE_ROWS_EVENTv0 || e.eventType == WRITE_ROWS_EVENTv1 || e.eventType == WRITE_ROWS_EVENTv2 || e.eventType == MARIADB_WRITE_ROWS_COMPRESSED_EVENT_V1
-}
-
-func (e *RowsEvent) IsUpdate() bool {
-	return e.eventType == UPDATE_ROWS_EVENTv0 || e.eventType == UPDATE_ROWS_EVENTv1 || e.eventType == UPDATE_ROWS_EVENTv2 || e.eventType == MARIADB_UPDATE_ROWS_COMPRESSED_EVENT_V1
-}
-
-func (e *RowsEvent) IsDelete() bool {
-	return e.eventType == DELETE_ROWS_EVENTv0 || e.eventType == DELETE_ROWS_EVENTv1 || e.eventType == DELETE_ROWS_EVENTv2 || e.eventType == MARIADB_DELETE_ROWS_COMPRESSED_EVENT_V1
+func (e *RowsEvent) Type() EnumRowsEventType {
+	switch e.eventType {
+	case WRITE_ROWS_EVENTv0, WRITE_ROWS_EVENTv1, WRITE_ROWS_EVENTv2, MARIADB_WRITE_ROWS_COMPRESSED_EVENT_V1:
+		return EnumRowsEventTypeInsert
+	case UPDATE_ROWS_EVENTv0, UPDATE_ROWS_EVENTv1, UPDATE_ROWS_EVENTv2, MARIADB_UPDATE_ROWS_COMPRESSED_EVENT_V1:
+		return EnumRowsEventTypeUpdate
+	case DELETE_ROWS_EVENTv0, DELETE_ROWS_EVENTv1, DELETE_ROWS_EVENTv2, MARIADB_DELETE_ROWS_COMPRESSED_EVENT_V1:
+		return EnumRowsEventTypeDelete
+	default:
+		return EnumRowsEventTypeUnknown
+	}
 }
 
 func isBitSet(bitmap []byte, i int) bool {

replication/row_event_test.go

@@ -1176,38 +1176,34 @@ func TestRowsDataExtraData(t *testing.T) {
 	}
 }
 
-func TestRowsEventTypoe(t *testing.T) {
+func TestRowsEventType(t *testing.T) {
 	testcases := []struct {
 		eventType EventType
-		isInsert  bool
-		isUpdate  bool
-		isDelete  bool
+		want      EnumRowsEventType
 	}{
-		{WRITE_ROWS_EVENTv0, true, false, false},
-		{WRITE_ROWS_EVENTv1, true, false, false},
-		{WRITE_ROWS_EVENTv2, true, false, false},
-		{MARIADB_WRITE_ROWS_COMPRESSED_EVENT_V1, true, false, false},
-		{UPDATE_ROWS_EVENTv0, false, true, false},
-		{UPDATE_ROWS_EVENTv1, false, true, false},
-		{UPDATE_ROWS_EVENTv2, false, true, false},
-		{MARIADB_UPDATE_ROWS_COMPRESSED_EVENT_V1, false, true, false},
-		{DELETE_ROWS_EVENTv0, false, false, true},
-		{DELETE_ROWS_EVENTv1, false, false, true},
-		{DELETE_ROWS_EVENTv2, false, false, true},
-		{MARIADB_DELETE_ROWS_COMPRESSED_EVENT_V1, false, false, true},
+		{WRITE_ROWS_EVENTv0, EnumRowsEventTypeInsert},
+		{WRITE_ROWS_EVENTv1, EnumRowsEventTypeInsert},
+		{WRITE_ROWS_EVENTv2, EnumRowsEventTypeInsert},
+		{MARIADB_WRITE_ROWS_COMPRESSED_EVENT_V1, EnumRowsEventTypeInsert},
+		{UPDATE_ROWS_EVENTv0, EnumRowsEventTypeUpdate},
+		{UPDATE_ROWS_EVENTv1, EnumRowsEventTypeUpdate},
+		{UPDATE_ROWS_EVENTv2, EnumRowsEventTypeUpdate},
+		{MARIADB_UPDATE_ROWS_COMPRESSED_EVENT_V1, EnumRowsEventTypeUpdate},
+		{DELETE_ROWS_EVENTv0, EnumRowsEventTypeDelete},
+		{DELETE_ROWS_EVENTv1, EnumRowsEventTypeDelete},
+		{DELETE_ROWS_EVENTv2, EnumRowsEventTypeDelete},
+		{MARIADB_DELETE_ROWS_COMPRESSED_EVENT_V1, EnumRowsEventTypeDelete},
 
 		// Whoops, these are not rows events at all
-		{EXEC_LOAD_EVENT, false, false, false},
-		{HEARTBEAT_EVENT, false, false, false},
+		{EXEC_LOAD_EVENT, EnumRowsEventTypeUnknown},
+		{HEARTBEAT_EVENT, EnumRowsEventTypeUnknown},
 	}
 
 	for _, tc := range testcases {
 		rev := new(RowsEvent)
 		rev.eventType = tc.eventType
 
-		require.Equal(t, tc.isInsert, rev.IsInsert())
-		require.Equal(t, tc.isUpdate, rev.IsUpdate())
-		require.Equal(t, tc.isDelete, rev.IsDelete())
+		require.Equal(t, tc.want, rev.Type())
 	}
 }