feedback

Co-authored-by: Daniël van Eeden <[email protected]>

Author: serprex

README.md

@@ -490,7 +490,7 @@ We pass all tests in https://github.com/bradfitz/go-sql-test using go-mysql driv
 
 ## Logging
 
-Logging uses log/slog.
+Logging uses [log/slog](https://pkg.go.dev/log/slog) and by default is sent to standard out.
 
 ## How to migrate to this repo
 To change the used package in your repo it's enough to add this `replace` directive to your `go.mod`:

canal/dump.go

@@ -50,7 +50,7 @@ func (h *dumpParseHandler) Data(db string, table string, values []string) error
 			e == schema.ErrMissingTableMeta {
 			return nil
 		}
-		h.c.cfg.Logger.Error("error getting table information", slog.String("databse", db), slog.String("table", table), slog.Any("error", err))
+		h.c.cfg.Logger.Error("error getting table information", slog.String("database", db), slog.String("table", table), slog.Any("error", err))
 		return errors.Trace(err)
 	}
 
@@ -164,7 +164,7 @@ func (c *Canal) dump() error {
 		if err != nil {
 			return errors.Trace(err)
 		}
-		c.cfg.Logger.Info("skip master data, get current binlog position", slog.Any("pos", pos))
+		c.cfg.Logger.Info("skip master data, get current binlog position", slog.Any("position", pos))
 		h.name = pos.Name
 		h.pos = uint64(pos.Pos)
 	}

replication/binlogsyncer.go

@@ -860,7 +860,7 @@ func (b *BinlogSyncer) handleEventAndACK(s *BinlogStreamer, e *BinlogEvent, need
 	case *RotateEvent:
 		b.nextPos.Name = string(event.NextLogName)
 		b.nextPos.Pos = uint32(event.Position)
-		b.cfg.Logger.Info(fmt.Sprintf("rotate to %s", b.nextPos))
+		b.cfg.Logger.Info("rotate to next binlog", slog.String("file", b.nextPos.Name), slog.Int("position", b.nextPos))
 
 	case *GTIDEvent:
 		if b.prevGset == nil {