fixing [email protected] errors of current build (#912)

* fixing [email protected] errors of currenet build

* more linting fixes for golangci-ling 1.60.3

Author: dvilaverde

driver/driver.go

@@ -203,7 +203,7 @@ func (c *conn) CheckNamedValue(nv *sqldriver.NamedValue) error {
 		} else {
 			// we've found an error, if the error is driver.ErrSkip then
 			// keep looking otherwise return the unknown error
-			if !goErrors.Is(sqldriver.ErrSkip, err) {
+			if !goErrors.Is(err, sqldriver.ErrSkip) {
 				return err
 			}
 		}

mysql/util.go

@@ -130,10 +130,13 @@ func AppendLengthEncodedInteger(b []byte, n uint64) []byte {
 
 func RandomBuf(size int) []byte {
 	buf := make([]byte, size)
-	mrand.Seed(time.Now().UTC().UnixNano())
+	// When this project supports golang 1.20 as a minimum, then this mrand.New(...)
+	// line can be eliminated and the random number can be generated by simply
+	// calling mrand.Intn()
+	random := mrand.New(mrand.NewSource(time.Now().UTC().UnixNano()))
 	min, max := 30, 127
 	for i := 0; i < size; i++ {
-		buf[i] = byte(min + mrand.Intn(max-min))
+		buf[i] = byte(min + random.Intn(max-min))
 	}
 	return buf
 }
@@ -197,11 +200,13 @@ func PutLengthEncodedInt(n uint64) []byte {
 	case n <= 0xffffff:
 		return []byte{0xfd, byte(n), byte(n >> 8), byte(n >> 16)}
 
-	case n <= 0xffffffffffffffff:
+	default:
+		// handles case n <= 0xffffffffffffffff
+		// using 'default' instead of 'case' to avoid static analysis error
+		// SA4003: every value of type uint64 is <= math.MaxUint64
 		return []byte{0xfe, byte(n), byte(n >> 8), byte(n >> 16), byte(n >> 24),
 			byte(n >> 32), byte(n >> 40), byte(n >> 48), byte(n >> 56)}
 	}
-	return nil
 }
 
 // LengthEncodedString returns the string read as a bytes slice, whether the value is NULL,