feat(canal): support ipv6 address

Author: sinomoe

canal/canal.go

@@ -481,17 +481,25 @@ func (c *Canal) prepareSyncer() error {
 	if strings.Contains(c.cfg.Addr, "/") {
 		cfg.Host = c.cfg.Addr
 	} else {
-		seps := strings.Split(c.cfg.Addr, ":")
-		if len(seps) != 2 {
-			return errors.Errorf("invalid mysql addr format %s, must host:port", c.cfg.Addr)
+		ipv6 := strings.Count(c.cfg.Addr, ":") > 1
+		if ipv6 && !strings.ContainsAny(c.cfg.Addr, "[]") {
+			return errors.Errorf("invalid mysql ipv6 addr format %s, must [host]:port", c.cfg.Addr)
 		}
-
-		port, err := strconv.ParseUint(seps[1], 10, 16)
+		lastSep := strings.LastIndex(c.cfg.Addr, ":")
+		if !ipv6 && lastSep == -1 {
+			return errors.Errorf("invalid mysql ipv4 addr format %s, must host:port", c.cfg.Addr)
+		}
+		addr := strings.Trim(c.cfg.Addr[:lastSep], "[]")
+		ip := net.ParseIP(addr)
+		if ip == nil {
+			return errors.Errorf("invalid mysql ip format %s", addr)
+		}
+		port, err := strconv.ParseUint(c.cfg.Addr[lastSep+1:], 10, 16)
 		if err != nil {
 			return errors.Trace(err)
 		}
 
-		cfg.Host = seps[0]
+		cfg.Host = addr
 		cfg.Port = uint16(port)
 	}
 

dump/dumper.go

@@ -212,10 +212,25 @@ func (d *Dumper) Dump(w io.Writer) error {
 	if strings.Contains(d.Addr, "/") {
 		args = append(args, fmt.Sprintf("--socket=%s", d.Addr))
 	} else {
-		seps := strings.SplitN(d.Addr, ":", 2)
-		args = append(args, fmt.Sprintf("--host=%s", seps[0]))
-		if len(seps) > 1 {
-			args = append(args, fmt.Sprintf("--port=%s", seps[1]))
+		ipv6 := strings.Count(d.Addr, ":") > 1
+		lastSep := strings.LastIndex(d.Addr, ":")
+		var host, port string
+		// without port
+		host = d.Addr
+		// ipv6 with port
+		if ipv6 && strings.ContainsAny(d.Addr, "[]") {
+			host = strings.Trim(d.Addr[:lastSep], "[]")
+			port = d.Addr[lastSep+1:]
+		}
+		// ipv4 with port
+		if !ipv6 && lastSep != -1 {
+			host = d.Addr[:lastSep]
+			port = d.Addr[lastSep+1:]
+		}
+
+		args = append(args, fmt.Sprintf("--host=%s", host))
+		if port != "" {
+			args = append(args, fmt.Sprintf("--port=%s", port))
 		}
 	}