add getShowBinaryLogQuery

Author: Guillem

canal/sync.go

@@ -324,21 +324,26 @@ func (c *Canal) WaitUntilPos(pos mysql.Position, timeout time.Duration) error {
 	}
 }
 
-func (c *Canal) GetMasterPos() (mysql.Position, error) {
-	query := "SHOW BINARY LOG STATUS"
+func (c *Canal) getShowBinaryLogQuery() string {
 	switch c.cfg.Flavor {
 	case mysql.MariaDBFlavor:
-		query = "SHOW BINLOG STATUS"
-
-		if eq, err := c.conn.CompareServerVersion("10.5.2"); (err == nil) && (eq < 0) {
-			query = "SHOW MASTER STATUS"
+		// Source: https://mariadb.com/kb/en/show-binlog-status/#:~:text=SHOW%20BINLOG%20STATUS%20%2D%2D-,From%20MariaDB%2010.5.2,-Description
+		if eq, err := c.conn.CompareServerVersion("10.5.2"); (err == nil) && (eq >= 0) {
+			return "SHOW BINLOG STATUS"
 		}
 	case mysql.MySQLFlavor:
-		if eq, err := c.conn.CompareServerVersion("8.4.0"); (err == nil) && (eq < 0) {
-			query = "SHOW MASTER STATUS"
+		// Source: https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html#:~:text=AND%20GTIDS)%3B-,SHOW%20MASTER%20STATUS,-(SHOW%20BINARY
+		if eq, err := c.conn.CompareServerVersion("8.4.0"); (err == nil) && (eq >= 0) {
+			return "SHOW BINARY LOG STATUS"
 		}
 	}
 
+	return "SHOW MASTER STATUS"
+}
+
+func (c *Canal) GetMasterPos() (mysql.Position, error) {
+	query := c.getShowBinaryLogQuery()
+
 	rr, err := c.Execute(query)
 	if err != nil {
 		return mysql.Position{}, errors.Trace(err)