Not all cases require client_secret

Arran Ubels · web-flow · commit 06c3b606d374 · 2020-07-07T09:14:11.000+10:00
It's likely that there might have be 2 of these functions or a switch involved
diff --git a/server/handler.go b/server/handler.go
@@ -46,10 +46,10 @@ type (
 // ClientFormHandler get client data from form
 func ClientFormHandler(r *http.Request) (string, string, error) {
 	clientID := r.Form.Get("client_id")
-	clientSecret := r.Form.Get("client_secret")
-	if clientID == "" || clientSecret == "" {
+	if clientID == "" {
 		return "", "", errors.ErrInvalidClient
 	}
+	clientSecret := r.Form.Get("client_secret")
 	return clientID, clientSecret, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -46,10 +46,10 @@ type (`
`46`	`46`	`// ClientFormHandler get client data from form`
`47`	`47`	`func ClientFormHandler(r *http.Request) (string, string, error) {`
`48`	`48`	`clientID := r.Form.Get("client_id")`
`49`		`- clientSecret := r.Form.Get("client_secret")`
`50`		`- if clientID == "" \|\| clientSecret == "" {`
	`49`	`+ if clientID == "" {`
`51`	`50`	`return "", "", errors.ErrInvalidClient`
`52`	`51`	`}`
	`52`	`+ clientSecret := r.Form.Get("client_secret")`
`53`	`53`	`return clientID, clientSecret, nil`
`54`	`54`	`}`
`55`	`55`