Skip to content

Commit d34e841

Browse files
author
rp8
committed
fixed the bug to compare client secrets when refreshing token
1 parent 68172d1 commit d34e841

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ _testmain.go
2323
*.test
2424
*.prof
2525

26+
coverage.txt
27+
2628
# OSX
2729
*.DS_Store
2830
*.db

manage/manager.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,10 @@ func (m *Manager) RefreshAccessToken(ctx context.Context, tgr *oauth2.TokenGener
363363
cli, err := m.GetClient(ctx, tgr.ClientID)
364364
if err != nil {
365365
return nil, err
366+
} else if cliPass, ok := cli.(oauth2.ClientPasswordVerifier); ok {
367+
if !cliPass.VerifyPassword(tgr.ClientSecret) {
368+
return nil, errors.ErrInvalidClient
369+
}
366370
} else if tgr.ClientSecret != cli.GetSecret() {
367371
return nil, errors.ErrInvalidClient
368372
}

server/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ func (s *Server) GetAuthorizeToken(ctx context.Context, req *AuthorizeRequest) (
240240
}
241241
}
242242

243-
tgr := &oauth2.TokenGenerateRequest{
243+
tgr = &oauth2.TokenGenerateRequest{
244244
ClientID: req.ClientID,
245245
UserID: req.UserID,
246246
RedirectURI: req.RedirectURI,

0 commit comments

Comments
 (0)