Skip to content

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Nov 15, 2025

  • enabled a few more linters: better to configure a linter with more relaxed settings than default than to disable it altogether
  • more detailed godoc
  • fixed missing license mark in recently addd source file

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

* enabled a few more linters: better to configure a linter with more
  relaxed settings than default than to disable it altogether
* more detailed godoc
* fixed missing license mark in recently addd source file

Signed-off-by: Frederic BIDON <[email protected]>
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.00%. Comparing base (c653a59) to head (aec0226).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pointer.go 62.50% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   78.46%   79.00%   +0.53%     
==========================================
  Files           2        2              
  Lines         274      281       +7     
==========================================
+ Hits          215      222       +7     
  Misses         40       40              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi
Copy link
Member Author

fredbi commented Nov 15, 2025

Need to address coverage issue on edge cases on a follow-up PR

@fredbi fredbi merged commit e4c97b3 into go-openapi:master Nov 15, 2025
17 of 18 checks passed
@fredbi fredbi deleted the chore/relint-again branch November 15, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant