Relint

* updated linter config
* fixed linting issues

Signed-off-by: Frederic BIDON <[email protected]>

Author: fredbi

.golangci.yml

@@ -1,12 +1,6 @@
 linters-settings:
-  govet:
-    check-shadowing: true
-  golint:
-    min-confidence: 0
   gocyclo:
     min-complexity: 45
-  maligned:
-    suggest-new: true
   dupl:
     threshold: 200
   goconst:
@@ -16,7 +10,6 @@ linters-settings:
 linters:
   enable-all: true
   disable:
-    - maligned
     - unparam
     - lll
     - gochecknoinits
@@ -29,17 +22,13 @@ linters:
     - wrapcheck
     - testpackage
     - nlreturn
-    - gomnd
-    - exhaustivestruct
-    - goerr113
     - errorlint
     - nestif
     - godot
     - gofumpt
     - paralleltest
     - tparallel
     - thelper
-    - ifshort
     - exhaustruct
     - varnamelen
     - gci
@@ -52,10 +41,15 @@ linters:
     - forcetypeassert
     - cyclop
     # deprecated linters
-    - deadcode
-    - interfacer
-    - scopelint
-    - varcheck
-    - structcheck
-    - golint
-    - nosnakecase
+    #- deadcode
+    #- interfacer
+    #- scopelint
+    #- varcheck
+    #- structcheck
+    #- golint
+    #- nosnakecase
+    #- maligned
+    #- goerr113
+    #- ifshort
+    #- gomnd
+    #- exhaustivestruct

reference.go

@@ -38,6 +38,8 @@ const (
 	fragmentRune = `#`
 )
 
+var ErrChildURL = errors.New("child url is nil")
+
 // New creates a new reference for the given string
 func New(jsonReferenceString string) (Ref, error) {
 
@@ -144,7 +146,7 @@ func (r *Ref) Inherits(child Ref) (*Ref, error) {
 	childURL := child.GetURL()
 	parentURL := r.GetURL()
 	if childURL == nil {
-		return nil, errors.New("child url is nil")
+		return nil, ErrChildURL
 	}
 	if parentURL == nil {
 		return &child, nil