Merge pull request #159 from vgogolev1703/patch-1

Revert "fix: *string(nil) not equal &string #152"

Author: casualjim

values.go

@@ -161,22 +161,10 @@ func ReadOnly(ctx context.Context, path, in string, data interface{}) *errors.Va
 func Required(path, in string, data interface{}) *errors.Validation {
 	val := reflect.ValueOf(data)
 	if val.IsValid() {
-		typ := reflect.TypeOf(data)
-		switch typ.Kind() {
-		case reflect.Pointer:
-			if val.IsNil() {
-				return errors.Required(path, in, data)
-			}
-			if reflect.DeepEqual(reflect.Zero(val.Elem().Type()).Interface(), val.Elem().Interface()) {
-				return errors.Required(path, in, data)
-			}
-			return nil
-		default:
-			if reflect.DeepEqual(reflect.Zero(val.Type()).Interface(), val.Interface()) {
-				return errors.Required(path, in, data)
-			}
-			return nil
+		if reflect.DeepEqual(reflect.Zero(val.Type()).Interface(), val.Interface()) {
+			return errors.Required(path, in, data)
 		}
+		return nil
 	}
 	return errors.Required(path, in, data)
 }

values_test.go

@@ -195,54 +195,22 @@ func TestValues_ValidateRequired(t *testing.T) {
 	path := "test"
 	in := "body"
 
-	emptyString := ""
-	emptyStringStruct := struct {
-		A *string
-	}{
-		A: &emptyString,
-	}
-
-	emptyNumber := 0
-	emptyNumberStruct := struct {
-		A *int
-	}{
-		A: &emptyNumber,
-	}
-
 	RequiredFail := []interface{}{
 		"",
 		0,
 		nil,
-		emptyStringStruct.A,
-		emptyNumberStruct.A,
 	}
 
 	for _, v := range RequiredFail {
 		err = Required(path, in, v)
 		assert.Error(t, err)
 	}
 
-	notEmptyString := "bla"
-	notEmptyStringStruct := struct {
-		A *string
-	}{
-		A: &notEmptyString,
-	}
-
-	notEmptyNumber := 1
-	notEmptyNumberStruct := struct {
-		A *int
-	}{
-		A: &notEmptyNumber,
-	}
-
 	RequiredSuccess := []interface{}{
 		" ",
 		"bla-bla-bla",
 		2,
 		[]interface{}{21, []int{}, "testString"},
-		notEmptyStringStruct.A,
-		notEmptyNumberStruct.A,
 	}
 
 	for _, v := range RequiredSuccess {