add interface tests + code cleanup

Author: joeybloggs

decoder.go

@@ -139,7 +139,6 @@ func (d *decoder) parseMapData() {
 
 func (d *decoder) traverseStruct(v reflect.Value, typ reflect.Type, namespace []byte) (set bool) {
 
-	// typ := v.Type()
 	l := len(namespace)
 	first := l == 0
 
@@ -195,7 +194,6 @@ func (d *decoder) setFieldByType(current reflect.Value, namespace []byte, idx in
 		}
 	}
 
-	// fmt.Println("KIND:", kind)
 	switch kind {
 	case reflect.Interface, reflect.Invalid:
 		return
@@ -546,7 +544,7 @@ func (d *decoder) setFieldByType(current reflect.Value, namespace []byte, idx in
 	case reflect.Struct:
 
 		typ := v.Type()
-		// fmt.Println("Type:", typ)
+
 		// if we get here then no custom time function declared so use RFC3339 by default
 		if typ == timeType {
 

decoder_test.go

@@ -1336,3 +1336,46 @@ func TestDecoderIncreasingKeys(t *testing.T) {
 	Equal(t, test2.Array[2], int(2))
 	Equal(t, test2.Array[10], int(10))
 }
+
+func TestDecoderInterface(t *testing.T) {
+
+	var iface interface{}
+
+	d := NewDecoder()
+
+	values := map[string][]string{
+		"": {"2"},
+	}
+
+	var i int
+
+	iface = &i
+
+	err := d.Decode(iface, values)
+	Equal(t, err, nil)
+	Equal(t, i, 2)
+
+	iface = i
+
+	PanicMatches(t, func() { d.Decode(iface, values) }, "interface must be a pointer")
+
+	values = map[string][]string{
+		"Value": {"testVal"},
+	}
+
+	type test struct {
+		Value string
+	}
+
+	var tst test
+
+	iface = &tst
+
+	err = d.Decode(iface, values)
+	Equal(t, err, nil)
+	Equal(t, tst.Value, "testVal")
+
+	iface = tst
+
+	PanicMatches(t, func() { d.Decode(iface, values) }, "interface must be a pointer")
+}