Skip to content

Commit 8b9a858

Browse files
joeybloggsjoeybloggs
authored andcommitted
update stack trace limit to use a variable for ease of configuring + tests.
1 parent fe02c9f commit 8b9a858

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

entry.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ func (e *Entry) WithFields(fields ...Field) LeveledLogger {
206206
func (e *Entry) StackTrace() LeveledLogger {
207207
trace := make([]byte, 1<<16)
208208
n := runtime.Stack(trace, true)
209-
if n > 7000 {
210-
n = 7000
209+
if n > stackTraceLimit {
210+
n = stackTraceLimit
211211
}
212212
e.Fields = append(e.Fields, F("stack trace", string(trace[:n])+"\n"))
213213
return e

log.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,11 @@ const (
4545

4646
// Logger is the default instance of the log package
4747
var (
48-
once sync.Once
49-
Logger *logger
50-
exitFunc = os.Exit
51-
skipLevel = 2
48+
once sync.Once
49+
Logger *logger
50+
exitFunc = os.Exit
51+
skipLevel = 2
52+
stackTraceLimit = 7000
5253
)
5354

5455
func init() {
@@ -255,8 +256,8 @@ func (l *logger) WithFields(fields ...Field) LeveledLogger {
255256
func (l *logger) StackTrace() LeveledLogger {
256257
trace := make([]byte, 1<<16)
257258
n := runtime.Stack(trace, true)
258-
if n > 7000 {
259-
n = 7000
259+
if n > stackTraceLimit {
260+
n = stackTraceLimit
260261
}
261262
return newEntry(DebugLevel, "", []Field{F("stack trace", string(trace[:n])+"\n")}, skipLevel)
262263
}

log_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
//
2222

2323
func TestConsoleLogger1(t *testing.T) {
24-
24+
stackTraceLimit = 1000
2525
tests := getLogTests1()
2626

2727
buff := new(bytes.Buffer)

pkg.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,8 @@ func WithFields(fields ...Field) LeveledLogger {
182182
func StackTrace() LeveledLogger {
183183
trace := make([]byte, 1<<16)
184184
n := runtime.Stack(trace, true)
185-
if n > 7000 {
186-
n = 7000
185+
if n > stackTraceLimit {
186+
n = stackTraceLimit
187187
}
188188
return newEntry(DebugLevel, "", []Field{F("stack trace", string(trace[:n])+"\n")}, skipLevel)
189189
}

pkg_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
//
2323

2424
func TestConsoleLogger2(t *testing.T) {
25-
25+
stackTraceLimit = 1000
2626
tests := getLogTests()
2727
buff := new(bytes.Buffer)
2828

0 commit comments

Comments
 (0)