General maintenance from go1.21 & 1.22 changes (#47)

Author: Dean Karn

.github/workflows/go.yml

@@ -38,6 +38,6 @@ jobs:
         with:
           go-version: stable
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v4
         with:
           version: latest

.gitignore

@@ -12,4 +12,4 @@
 
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
-
+.idea

CHANGELOG.md

@@ -6,6 +6,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [5.28.0] - 2024-02-13
+### Added
+- Additionally supported types, cast to `sql.Valuer` supported types.
+
+### Changed
+- Option scan to take advantage of new `sql.Null` and `reflect.TypeFor` for go1.22+.
+- `BytesToString` & `StringToBytes` to use `unsafe.String` & `unsafe.Slice` for go1.21+.
+
+### Deprecated
+- `mathext.Min` & `mathext.Max` in favour of std lib min & max.
+
+### Fixed
+- Some documentation typos.
+
 ## [5.27.0] - 2024-01-29
 ### Changed
 - `sliceext.Retain` & `sliceext.Filter` to not shuffle data in the underlying slice array but create new slice referencing the data instead. In practice, it can cause unexpected behaviour and users expectations not met when the same data is also referenced elsewhere. If anyone still requires a `shuffle` implementation for efficiency I'd be happy to add a separate function for that as well.
@@ -102,7 +116,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Added `timext.NanoTime` for fast low level monotonic time with nanosecond precision.
 
-[Unreleased]: https://github.com/go-playground/pkg/compare/v5.26.0...HEAD
+[Unreleased]: https://github.com/go-playground/pkg/compare/v5.28.0...HEAD
+[5.28.0]: https://github.com/go-playground/pkg/compare/v5.27.0..v5.28.0
+[5.27.0]: https://github.com/go-playground/pkg/compare/v5.26.0..v5.27.0
 [5.26.0]: https://github.com/go-playground/pkg/compare/v5.25.0..v5.26.0
 [5.25.0]: https://github.com/go-playground/pkg/compare/v5.24.0..v5.25.0
 [5.24.0]: https://github.com/go-playground/pkg/compare/v5.23.0..v5.24.0

README.md

@@ -1,6 +1,6 @@
 # pkg
 
-![Project status](https://img.shields.io/badge/version-5.27.0-green.svg)
+![Project status](https://img.shields.io/badge/version-5.28.0-green.svg)
 [![Lint & Test](https://github.com/go-playground/pkg/actions/workflows/go.yml/badge.svg)](https://github.com/go-playground/pkg/actions/workflows/go.yml)
 [![Coverage Status](https://coveralls.io/repos/github/go-playground/pkg/badge.svg?branch=master)](https://coveralls.io/github/go-playground/pkg?branch=master)
 [![GoDoc](https://godoc.org/github.com/go-playground/pkg?status.svg)](https://pkg.go.dev/mod/github.com/go-playground/pkg/v5)

math/max.go

@@ -1,11 +1,12 @@
-//go:build go1.18
-// +build go1.18
+//go:build go1.18 && !go1.21
+// +build go1.18,!go1.21
 
 package mathext
 
 import (
-	constraintsext "github.com/go-playground/pkg/v5/constraints"
 	"math"
+
+	constraintsext "github.com/go-playground/pkg/v5/constraints"
 )
 
 // Max returns the larger value.

math/max_go121.go

@@ -0,0 +1,16 @@
+//go:build go1.21
+
+package mathext
+
+import (
+	constraintsext "github.com/go-playground/pkg/v5/constraints"
+)
+
+// Max returns the larger value.
+//
+// NOTE: this function does not check for difference in floats of 0/zero vs -0/negative zero using Signbit.
+//
+// Deprecated: use the new std library `max` instead.
+func Max[N constraintsext.Number](x, y N) N {
+	return max(x, y)
+}

math/min.go

@@ -1,11 +1,12 @@
-//go:build go1.18
-// +build go1.18
+//go:build go1.18 && !go1.21
+// +build go1.18,!go1.21
 
 package mathext
 
 import (
-	constraintsext "github.com/go-playground/pkg/v5/constraints"
 	"math"
+
+	constraintsext "github.com/go-playground/pkg/v5/constraints"
 )
 
 // Min returns the smaller value.

math/min_go121.go

@@ -0,0 +1,16 @@
+//go:build go1.21
+
+package mathext
+
+import (
+	constraintsext "github.com/go-playground/pkg/v5/constraints"
+)
+
+// Min returns the smaller value.
+//
+// NOTE: this function does not check for difference in floats of 0/zero vs -0/negative zero using Signbit.
+//
+// Deprecated: use the new std library `max` instead.
+func Min[N constraintsext.Number](x, y N) N {
+	return min(x, y)
+}

net/http/helpers.go

@@ -59,7 +59,7 @@ func AcceptedLanguages(r *http.Request) (languages []string) {
 	return
 }
 
-// Attachment is a helper method for returning an attachement file
+// Attachment is a helper method for returning an attachment file
 // to be downloaded, if you with to open inline see function Inline
 func Attachment(w http.ResponseWriter, r io.Reader, filename string) (err error) {
 	w.Header().Set(ContentDisposition, "attachment;filename="+filename)
@@ -79,7 +79,7 @@ func Inline(w http.ResponseWriter, r io.Reader, filename string) (err error) {
 	return
 }
 
-// ClientIP implements a best effort algorithm to return the real client IP, it parses
+// ClientIP implements the best effort algorithm to return the real client IP, it parses
 // X-Real-IP and X-Forwarded-For in order to work properly with reverse-proxies such us: nginx or haproxy.
 func ClientIP(r *http.Request) (clientIP string) {
 	values := r.Header[XRealIP]
@@ -103,7 +103,7 @@ func ClientIP(r *http.Request) (clientIP string) {
 	return
 }
 
-// JSONStream uses json.Encoder to stream the JSON reponse body.
+// JSONStream uses json.Encoder to stream the JSON response body.
 //
 // This differs from the JSON helper which unmarshalls into memory first allowing the capture of JSON encoding errors.
 func JSONStream(w http.ResponseWriter, status int, i interface{}) error {

net/http/retryable.go

@@ -6,11 +6,12 @@ package httpext
 import (
 	"context"
 	"fmt"
-	bytesext "github.com/go-playground/pkg/v5/bytes"
-	errorsext "github.com/go-playground/pkg/v5/errors"
-	resultext "github.com/go-playground/pkg/v5/values/result"
 	"net/http"
 	"strconv"
+
+	bytesext "github.com/go-playground/pkg/v5/bytes"
+	errorsext "github.com/go-playground/pkg/v5/errors"
+	. "github.com/go-playground/pkg/v5/values/result"
 )
 
 var (
@@ -59,39 +60,39 @@ type BuildRequestFn func(ctx context.Context) (*http.Request, error)
 type IsRetryableStatusCodeFn func(code int) bool
 
 // DoRetryableResponse will execute the provided functions code and automatically retry before returning the *http.Response.
-func DoRetryableResponse(ctx context.Context, onRetryFn errorsext.OnRetryFn[error], isRetryableStatusCode IsRetryableStatusCodeFn, client *http.Client, buildFn BuildRequestFn) resultext.Result[*http.Response, error] {
+func DoRetryableResponse(ctx context.Context, onRetryFn errorsext.OnRetryFn[error], isRetryableStatusCode IsRetryableStatusCodeFn, client *http.Client, buildFn BuildRequestFn) Result[*http.Response, error] {
 	if client == nil {
 		client = http.DefaultClient
 	}
 	var attempt int
 	for {
 		req, err := buildFn(ctx)
 		if err != nil {
-			return resultext.Err[*http.Response, error](err)
+			return Err[*http.Response, error](err)
 		}
 
 		resp, err := client.Do(req)
 		if err != nil {
 			if retryReason, isRetryable := errorsext.IsRetryableHTTP(err); isRetryable {
 				opt := onRetryFn(ctx, err, retryReason, attempt)
 				if opt.IsSome() {
-					return resultext.Err[*http.Response, error](opt.Unwrap())
+					return Err[*http.Response, error](opt.Unwrap())
 				}
 				attempt++
 				continue
 			}
-			return resultext.Err[*http.Response, error](err)
+			return Err[*http.Response, error](err)
 		}
 
 		if isRetryableStatusCode(resp.StatusCode) {
 			opt := onRetryFn(ctx, ErrRetryableStatusCode{Response: resp}, strconv.Itoa(resp.StatusCode), attempt)
 			if opt.IsSome() {
-				return resultext.Err[*http.Response, error](opt.Unwrap())
+				return Err[*http.Response, error](opt.Unwrap())
 			}
 			attempt++
 			continue
 		}
-		return resultext.Ok[*http.Response, error](resp)
+		return Ok[*http.Response, error](resp)
 	}
 }
 
@@ -101,25 +102,25 @@ func DoRetryableResponse(ctx context.Context, onRetryFn errorsext.OnRetryFn[erro
 // Gzip supported:
 // - JSON
 // - XML
-func DoRetryable[T any](ctx context.Context, isRetryableFn errorsext.IsRetryableFn[error], onRetryFn errorsext.OnRetryFn[error], isRetryableStatusCode IsRetryableStatusCodeFn, client *http.Client, expectedResponseCode int, maxMemory bytesext.Bytes, buildFn BuildRequestFn) resultext.Result[T, error] {
+func DoRetryable[T any](ctx context.Context, isRetryableFn errorsext.IsRetryableFn[error], onRetryFn errorsext.OnRetryFn[error], isRetryableStatusCode IsRetryableStatusCodeFn, client *http.Client, expectedResponseCode int, maxMemory bytesext.Bytes, buildFn BuildRequestFn) Result[T, error] {
 
-	return errorsext.DoRetryable(ctx, isRetryableFn, onRetryFn, func(ctx context.Context) resultext.Result[T, error] {
+	return errorsext.DoRetryable(ctx, isRetryableFn, onRetryFn, func(ctx context.Context) Result[T, error] {
 
 		result := DoRetryableResponse(ctx, onRetryFn, isRetryableStatusCode, client, buildFn)
 		if result.IsErr() {
-			return resultext.Err[T, error](result.Err())
+			return Err[T, error](result.Err())
 		}
 		resp := result.Unwrap()
 
 		if resp.StatusCode != expectedResponseCode {
-			return resultext.Err[T, error](ErrUnexpectedResponse{Response: resp})
+			return Err[T, error](ErrUnexpectedResponse{Response: resp})
 		}
 		defer resp.Body.Close()
 
 		data, err := DecodeResponse[T](resp, maxMemory)
 		if err != nil {
-			return resultext.Err[T, error](err)
+			return Err[T, error](err)
 		}
-		return resultext.Ok[T, error](data)
+		return Ok[T, error](data)
 	})
 }