Skip to content

Commit 06ad249

Browse files
Dean KarnDean Karn
authored andcommitted
Merge pull request #118 from joeybloggs/v6-development
V6 development
2 parents b009996 + cdc48b4 commit 06ad249

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

validator.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,9 @@ func (v *Validate) traverseField(topStruct reflect.Value, currentStruct reflect.
254254
return
255255
}
256256

257-
tags := strings.Split(tag, tagSeparator)
258-
259-
if len(tags) > 0 {
257+
if len(tag) > 0 {
260258

259+
tags := strings.Split(tag, tagSeparator)
261260
var param string
262261
vals := strings.SplitN(tags[0], tagKeySeparator, 2)
263262

validator_test.go

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,19 @@ func AssertError(t *testing.T, errs ValidationErrors, key, field, expectedTag st
229229
EqualSkip(t, 2, val.Tag, expectedTag)
230230
}
231231

232+
func TestDatePtrValidationIssueValidation(t *testing.T) {
233+
234+
type Test struct {
235+
LastViewed *time.Time
236+
Reminder *time.Time
237+
}
238+
239+
test := &Test{}
240+
241+
errs := validate.Struct(test)
242+
Equal(t, errs, nil)
243+
}
244+
232245
func TestCommaAndPipeObfuscationValidation(t *testing.T) {
233246
s := "My Name Is, |joeybloggs|"
234247

@@ -634,13 +647,12 @@ func TestArrayDiveValidation(t *testing.T) {
634647

635648
errs = validate.Struct(tmsp)
636649
NotEqual(t, errs, nil)
637-
Equal(t, len(errs), 6)
650+
Equal(t, len(errs), 5)
638651
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[0][1].Name", "Name", "required")
639652
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[0][2].Name", "Name", "required")
640653
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[1][1].Name", "Name", "required")
641654
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[1][2].Name", "Name", "required")
642655
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[2][1].Name", "Name", "required")
643-
AssertError(t, errs, "TestMultiDimensionalStructsPtr.Errs[2][2]", "Errs[2][2]", "")
644656
// for full test coverage
645657
fmt.Sprint(errs.Error())
646658

0 commit comments

Comments
 (0)