Skip to content

Commit 3d65a9b

Browse files
authored
Fix Japanese translation of max-items, lt-items and lte-items error (#1250)
## Fixes In English version, max-items error message is `"{0} must contain at maximum {1}"`. ([ref](https://github.com/go-playground/validator/blob/master/translations/en/en.go#L292)) And current Japanese translation `"{0}は最大でも{1}を含まなければなりません"` is strait translation of English version but quite unnatural for Japanese. We don’t usually use a sentence like `"含まなければなりません"` ("must contain") in this context. Because it can not **"contain"** any items further. So, we simply say `"{0}は最大でも{1}でなければなりません"` ("{0} must be at maximum {1}") instead. `"lt-items"` and `"lte-items"` messages have same issue as above. (if those errors occur, it can not contain any items further as well.) --- **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
1 parent d3e28c4 commit 3d65a9b

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

translations/ja/ja.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
230230
return
231231
}
232232

233-
if err = ut.Add("max-items", "{0}は最大でも{1}を含まなければなりません", false); err != nil {
233+
if err = ut.Add("max-items", "{0}は最大でも{1}でなければなりません", false); err != nil {
234234
return
235235
}
236236
// if err = ut.AddCardinal("max-items-item", "{0}つの項目", locales.PluralRuleOne, false); err != nil {
@@ -405,7 +405,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
405405
return
406406
}
407407

408-
if err = ut.Add("lt-items", "{0}は{1}よりも少ない項目を含まなければなりません", false); err != nil {
408+
if err = ut.Add("lt-items", "{0}は{1}よりも少ない項目でなければなりません", false); err != nil {
409409
return
410410
}
411411

@@ -525,7 +525,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
525525
return
526526
}
527527

528-
if err = ut.Add("lte-items", "{0}は最大でも{1}を含まなければなりません", false); err != nil {
528+
if err = ut.Add("lte-items", "{0}は最大でも{1}でなければなりません", false); err != nil {
529529
return
530530
}
531531

translations/ja/ja_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ func TestTranslations(t *testing.T) {
518518
},
519519
{
520520
ns: "Test.LteMultiple",
521-
expected: "LteMultipleは最大でも2つの項目を含まなければなりません",
521+
expected: "LteMultipleは最大でも2つの項目でなければなりません",
522522
},
523523
{
524524
ns: "Test.LteTime",
@@ -534,7 +534,7 @@ func TestTranslations(t *testing.T) {
534534
},
535535
{
536536
ns: "Test.LtMultiple",
537-
expected: "LtMultipleは2つの項目よりも少ない項目を含まなければなりません",
537+
expected: "LtMultipleは2つの項目よりも少ない項目でなければなりません",
538538
},
539539
{
540540
ns: "Test.LtTime",
@@ -574,7 +574,7 @@ func TestTranslations(t *testing.T) {
574574
},
575575
{
576576
ns: "Test.MaxMultiple",
577-
expected: "MaxMultipleは最大でも7つの項目を含まなければなりません",
577+
expected: "MaxMultipleは最大でも7つの項目でなければなりません",
578578
},
579579
{
580580
ns: "Test.MinString",

0 commit comments

Comments
 (0)