Update linter to v2.0.2 (#1405)

## Fixes Or Enhances
Recently, the Dependabot
[PR](#1403) for the
linter update failed.
This PR updates the linter to `v2.0.2`, adds a linter configuration
file, and addresses some obvious errors:
- Error return value of `file.Close` is not checked (errcheck)
- Error return value of `os.Remove` is not checked (errcheck)
- could use strings.ReplaceAll instead (staticcheck)
- could omit type interface{} from declaration; it will be inferred from
the right-hand side (staticcheck)


**Make sure that you've checked the boxes below before you submit PR:**
- [ ] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers

Author: nodivbyzero

.github/workflows/workflow.yml

@@ -38,6 +38,6 @@ jobs:
         with:
           go-version: 1.24.x
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
           version: latest

.golangci.yaml

@@ -0,0 +1,102 @@
+version: "2"
+linters:
+  default: all
+  disable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - canonicalheader
+    - containedctx
+    - contextcheck
+    - copyloopvar
+    - cyclop
+    - decorder
+    - depguard
+    - dogsled
+    - dupl
+    - dupword
+    - durationcheck
+    - err113
+    - errcheck
+    - errchkjson
+    - errname
+    - errorlint
+    - exhaustive
+    - exhaustruct
+    - exptostd
+    - fatcontext
+    - forbidigo
+    - forcetypeassert
+    - funlen
+    - ginkgolinter
+    - gocheckcompilerdirectives
+    - gochecknoglobals
+    - gochecknoinits
+    - gochecksumtype
+    - gocognit
+    - goconst
+    - gocritic
+    - gocyclo
+    - godot
+    - godox
+    - goheader
+    - gomoddirectives
+    - gomodguard
+    - goprintffuncname
+    - gosec
+    - gosmopolitan
+    - govet
+    - grouper
+    - iface
+    - importas
+    - inamedparam
+    - ineffassign
+    - interfacebloat
+    - intrange
+    - ireturn
+    - lll
+    - loggercheck
+    - maintidx
+    - makezero
+    - mirror
+    - misspell
+    - mnd
+    - musttag
+    - nakedret
+    - nestif
+    - nilerr
+    - nilnesserr
+    - nilnil
+    - nlreturn
+    - noctx
+    - nolintlint
+    - nonamedreturns
+    - nosprintfhostport
+    - paralleltest
+    - perfsprint
+    - prealloc
+    - predeclared
+    - promlinter
+    - protogetter
+    - reassign
+    - recvcheck
+    - revive
+    - rowserrcheck
+    - sloglint
+    - spancheck
+    - sqlclosecheck
+    - staticcheck
+    - tagalign
+    - tagliatelle
+    - testableexamples
+    - testifylint
+    - testpackage
+    - thelper
+    - tparallel
+    - unparam
+    - varnamelen
+    - whitespace
+    - wrapcheck
+    - wsl
+    - zerologlint

Makefile

@@ -3,7 +3,7 @@ GOCMD=go
 linters-install:
 	@golangci-lint --version >/dev/null 2>&1 || { \
 		echo "installing linting tools..."; \
-		curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v1.41.1; \
+		curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s v2.0.2; \
 	}
 
 lint: linters-install

baked_in.go

@@ -260,7 +260,7 @@ func parseOneOfParam2(s string) []string {
 		oneofValsCacheRWLock.Lock()
 		vals = splitParamsRegex().FindAllString(s, -1)
 		for i := 0; i < len(vals); i++ {
-			vals[i] = strings.Replace(vals[i], "'", "", -1)
+			vals[i] = strings.ReplaceAll(vals[i], "'", "")
 		}
 		oneofValsCache[s] = vals
 		oneofValsCacheRWLock.Unlock()
@@ -1619,7 +1619,9 @@ func isImage(fl FieldLevel) bool {
 		if err != nil {
 			return false
 		}
-		defer file.Close()
+		defer func() {
+			_ = file.Close()
+		}()
 
 		mime, err := mimetype.DetectReader(file)
 		if err != nil {

cache.go

@@ -309,7 +309,7 @@ func (v *Validate) parseFieldTagsRecursive(tag string, fieldName string, alias s
 				}
 
 				if len(vals) > 1 {
-					current.param = strings.Replace(strings.Replace(vals[1], utf8HexComma, ",", -1), utf8Pipe, "|", -1)
+					current.param = strings.ReplaceAll(strings.ReplaceAll(vals[1], utf8HexComma, ","), utf8Pipe, "|")
 				}
 			}
 			current.isBlockEnd = true

validator_test.go

@@ -3088,7 +3088,7 @@ func TestBadKeyValidation(t *testing.T) {
 
 func TestInterfaceErrValidation(t *testing.T) {
 	var v2 interface{} = 1
-	var v1 interface{} = v2
+	var v1 = v2
 
 	validate := New()
 	errs := validate.Var(v1, "len=1")
@@ -5941,13 +5941,15 @@ func TestFileValidation(t *testing.T) {
 func TestImageValidation(t *testing.T) {
 	validate := New()
 
+	tmpDir := t.TempDir()
+
 	paths := map[string]string{
 		"empty":     "",
 		"directory": "testdata",
-		"missing":   filepath.Join("testdata", "none.png"),
-		"png":       filepath.Join("testdata", "image.png"),
-		"jpeg":      filepath.Join("testdata", "image.jpg"),
-		"mp3":       filepath.Join("testdata", "music.mp3"),
+		"missing":   filepath.Join(tmpDir, "none.png"),
+		"png":       filepath.Join(tmpDir, "image.png"),
+		"jpeg":      filepath.Join(tmpDir, "image.jpg"),
+		"mp3":       filepath.Join(tmpDir, "music.mp3"),
 	}
 
 	tests := []struct {
@@ -5983,14 +5985,18 @@ func TestImageValidation(t *testing.T) {
 			true,
 			func() {
 				img := image.NewRGBA(image.Rectangle{image.Point{0, 0}, image.Point{10, 10}})
-				f, _ := os.Create(paths["png"])
-				err := png.Encode(f, img)
-				if err != nil {
-					panic(fmt.Sprintf("Could not encode file in PNG. Error: %s", err))
-				}
+				f, err := os.Create(paths["png"])
+				Equal(t, err, nil)
+				defer func() {
+					_ = f.Close()
+				}()
+
+				err = png.Encode(f, img)
+				Equal(t, err, nil)
 			},
 			func() {
-				os.Remove(paths["png"])
+				err := os.Remove(paths["png"])
+				Equal(t, err, nil)
 			},
 		},
 		{
@@ -6000,14 +6006,18 @@ func TestImageValidation(t *testing.T) {
 			func() {
 				var opt jpeg.Options
 				img := image.NewGray(image.Rect(0, 0, 10, 10))
-				f, _ := os.Create(paths["jpeg"])
-				err := jpeg.Encode(f, img, &opt)
-				if err != nil {
-					panic(fmt.Sprintf("Could not encode file in JPEG. Error: %s", err))
-				}
+				f, err := os.Create(paths["jpeg"])
+				Equal(t, err, nil)
+				defer func() {
+					_ = f.Close()
+				}()
+
+				err = jpeg.Encode(f, img, &opt)
+				Equal(t, err, nil)
 			},
 			func() {
-				os.Remove(paths["jpeg"])
+				err := os.Remove(paths["jpeg"])
+				Equal(t, err, nil)
 			},
 		},
 		{