Skip to content

Commit b250b44

Browse files
author
Dean Karn
committed
Update test & benchmarks
- Updated failing test for new translation error message. - Updated benchmarks with new machine at the same time.
1 parent 691ea55 commit b250b44

File tree

2 files changed

+55
-55
lines changed

2 files changed

+55
-55
lines changed

‎README.md‎

Lines changed: 54 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Package validator
22
================
33
<img align="right" src="https://raw.githubusercontent.com/go-playground/validator/v9/logo.png">
44
[![Join the chat at https://gitter.im/go-playground/validator](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/go-playground/validator?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
5-
![Project status](https://img.shields.io/badge/version-9.3.3-green.svg)
5+
![Project status](https://img.shields.io/badge/version-9.3.4-green.svg)
66
[![Build Status](https://semaphoreci.com/api/v1/joeybloggs/validator/branches/v9/badge.svg)](https://semaphoreci.com/joeybloggs/validator)
77
[![Coverage Status](https://coveralls.io/repos/go-playground/validator/badge.svg?branch=v9&service=github)](https://coveralls.io/github/go-playground/validator?branch=v9)
88
[![Go Report Card](https://goreportcard.com/badge/github.com/go-playground/validator)](https://goreportcard.com/report/github.com/go-playground/validator)
@@ -66,60 +66,60 @@ Please see http://godoc.org/gopkg.in/go-playground/validator.v9 for detailed usa
6666

6767
Benchmarks
6868
------
69-
###### Run on MacBook Pro (Retina, 15-inch, Late 2013) 2.6 GHz Intel Core i7 16 GB 1600 MHz DDR3 using Go version go1.7.4 darwin/amd64
69+
###### Run on i5-7600 16 GB 1600 MHz DDR4 using Go version go1.7.5 darwin/amd64
7070
```go
71-
BenchmarkFieldSuccess-8 20000000 107 ns/op 0 B/op 0 allocs/op
72-
BenchmarkFieldSuccessParallel-8 50000000 33.6 ns/op 0 B/op 0 allocs/op
73-
BenchmarkFieldFailure-8 5000000 333 ns/op 208 B/op 4 allocs/op
74-
BenchmarkFieldFailureParallel-8 20000000 117 ns/op 208 B/op 4 allocs/op
75-
BenchmarkFieldDiveSuccess-8 2000000 766 ns/op 201 B/op 11 allocs/op
76-
BenchmarkFieldDiveSuccessParallel-8 10000000 232 ns/op 201 B/op 11 allocs/op
77-
BenchmarkFieldDiveFailure-8 2000000 1000 ns/op 412 B/op 16 allocs/op
78-
BenchmarkFieldDiveFailureParallel-8 5000000 337 ns/op 413 B/op 16 allocs/op
79-
BenchmarkFieldCustomTypeSuccess-8 5000000 264 ns/op 32 B/op 2 allocs/op
80-
BenchmarkFieldCustomTypeSuccessParallel-8 20000000 83.5 ns/op 32 B/op 2 allocs/op
81-
BenchmarkFieldCustomTypeFailure-8 5000000 343 ns/op 208 B/op 4 allocs/op
82-
BenchmarkFieldCustomTypeFailureParallel-8 20000000 122 ns/op 208 B/op 4 allocs/op
83-
BenchmarkFieldOrTagSuccess-8 2000000 872 ns/op 16 B/op 1 allocs/op
84-
BenchmarkFieldOrTagSuccessParallel-8 3000000 410 ns/op 16 B/op 1 allocs/op
85-
BenchmarkFieldOrTagFailure-8 3000000 569 ns/op 224 B/op 5 allocs/op
86-
BenchmarkFieldOrTagFailureParallel-8 3000000 407 ns/op 224 B/op 5 allocs/op
87-
BenchmarkStructLevelValidationSuccess-8 5000000 268 ns/op 32 B/op 2 allocs/op
88-
BenchmarkStructLevelValidationSuccessParallel-8 20000000 83.3 ns/op 32 B/op 2 allocs/op
89-
BenchmarkStructLevelValidationFailure-8 3000000 567 ns/op 304 B/op 8 allocs/op
90-
BenchmarkStructLevelValidationFailureParallel-8 10000000 204 ns/op 304 B/op 8 allocs/op
91-
BenchmarkStructSimpleCustomTypeSuccess-8 3000000 457 ns/op 32 B/op 2 allocs/op
92-
BenchmarkStructSimpleCustomTypeSuccessParallel-8 10000000 136 ns/op 32 B/op 2 allocs/op
93-
BenchmarkStructSimpleCustomTypeFailure-8 2000000 757 ns/op 424 B/op 9 allocs/op
94-
BenchmarkStructSimpleCustomTypeFailureParallel-8 5000000 310 ns/op 440 B/op 10 allocs/op
95-
BenchmarkStructFilteredSuccess-8 2000000 678 ns/op 288 B/op 9 allocs/op
96-
BenchmarkStructFilteredSuccessParallel-8 10000000 258 ns/op 288 B/op 9 allocs/op
97-
BenchmarkStructFilteredFailure-8 3000000 521 ns/op 256 B/op 7 allocs/op
98-
BenchmarkStructFilteredFailureParallel-8 10000000 197 ns/op 256 B/op 7 allocs/op
99-
BenchmarkStructPartialSuccess-8 2000000 602 ns/op 256 B/op 6 allocs/op
100-
BenchmarkStructPartialSuccessParallel-8 10000000 241 ns/op 256 B/op 6 allocs/op
101-
BenchmarkStructPartialFailure-8 2000000 866 ns/op 480 B/op 11 allocs/op
102-
BenchmarkStructPartialFailureParallel-8 5000000 347 ns/op 480 B/op 11 allocs/op
103-
BenchmarkStructExceptSuccess-8 2000000 955 ns/op 496 B/op 12 allocs/op
104-
BenchmarkStructExceptSuccessParallel-8 10000000 209 ns/op 240 B/op 5 allocs/op
105-
BenchmarkStructExceptFailure-8 2000000 809 ns/op 464 B/op 10 allocs/op
106-
BenchmarkStructExceptFailureParallel-8 5000000 335 ns/op 464 B/op 10 allocs/op
107-
BenchmarkStructSimpleCrossFieldSuccess-8 3000000 469 ns/op 72 B/op 3 allocs/op
108-
BenchmarkStructSimpleCrossFieldSuccessParallel-8 10000000 167 ns/op 72 B/op 3 allocs/op
109-
BenchmarkStructSimpleCrossFieldFailure-8 2000000 714 ns/op 304 B/op 8 allocs/op
110-
BenchmarkStructSimpleCrossFieldFailureParallel-8 5000000 278 ns/op 304 B/op 8 allocs/op
111-
BenchmarkStructSimpleCrossStructCrossFieldSuccess-8 2000000 660 ns/op 80 B/op 4 allocs/op
112-
BenchmarkStructSimpleCrossStructCrossFieldSuccessParallel-8 10000000 244 ns/op 80 B/op 4 allocs/op
113-
BenchmarkStructSimpleCrossStructCrossFieldFailure-8 2000000 939 ns/op 320 B/op 9 allocs/op
114-
BenchmarkStructSimpleCrossStructCrossFieldFailureParallel-8 5000000 382 ns/op 320 B/op 9 allocs/op
115-
BenchmarkStructSimpleSuccess-8 5000000 287 ns/op 0 B/op 0 allocs/op
116-
BenchmarkStructSimpleSuccessParallel-8 20000000 90.5 ns/op 0 B/op 0 allocs/op
117-
BenchmarkStructSimpleFailure-8 2000000 712 ns/op 424 B/op 9 allocs/op
118-
BenchmarkStructSimpleFailureParallel-8 5000000 298 ns/op 424 B/op 9 allocs/op
119-
BenchmarkStructComplexSuccess-8 1000000 1645 ns/op 128 B/op 8 allocs/op
120-
BenchmarkStructComplexSuccessParallel-8 3000000 544 ns/op 128 B/op 8 allocs/op
121-
BenchmarkStructComplexFailure-8 300000 4688 ns/op 3041 B/op 53 allocs/op
122-
BenchmarkStructComplexFailureParallel-8 1000000 2064 ns/op 3041 B/op 53 allocs/op
71+
BenchmarkFieldSuccess-4 20000000 84.7 ns/op 0 B/op 0 allocs/op
72+
BenchmarkFieldSuccessParallel-4 50000000 31.0 ns/op 0 B/op 0 allocs/op
73+
BenchmarkFieldFailure-4 5000000 299 ns/op 208 B/op 4 allocs/op
74+
BenchmarkFieldFailureParallel-4 20000000 104 ns/op 208 B/op 4 allocs/op
75+
BenchmarkFieldDiveSuccess-4 2000000 637 ns/op 201 B/op 11 allocs/op
76+
BenchmarkFieldDiveSuccessParallel-4 10000000 191 ns/op 201 B/op 11 allocs/op
77+
BenchmarkFieldDiveFailure-4 2000000 895 ns/op 412 B/op 16 allocs/op
78+
BenchmarkFieldDiveFailureParallel-4 5000000 280 ns/op 412 B/op 16 allocs/op
79+
BenchmarkFieldCustomTypeSuccess-4 10000000 222 ns/op 32 B/op 2 allocs/op
80+
BenchmarkFieldCustomTypeSuccessParallel-4 20000000 70.9 ns/op 32 B/op 2 allocs/op
81+
BenchmarkFieldCustomTypeFailure-4 5000000 313 ns/op 208 B/op 4 allocs/op
82+
BenchmarkFieldCustomTypeFailureParallel-4 20000000 103 ns/op 208 B/op 4 allocs/op
83+
BenchmarkFieldOrTagSuccess-4 2000000 743 ns/op 16 B/op 1 allocs/op
84+
BenchmarkFieldOrTagSuccessParallel-4 3000000 485 ns/op 16 B/op 1 allocs/op
85+
BenchmarkFieldOrTagFailure-4 3000000 530 ns/op 224 B/op 5 allocs/op
86+
BenchmarkFieldOrTagFailureParallel-4 3000000 402 ns/op 224 B/op 5 allocs/op
87+
BenchmarkStructLevelValidationSuccess-4 10000000 216 ns/op 32 B/op 2 allocs/op
88+
BenchmarkStructLevelValidationSuccessParallel-4 20000000 68.4 ns/op 32 B/op 2 allocs/op
89+
BenchmarkStructLevelValidationFailure-4 3000000 517 ns/op 304 B/op 8 allocs/op
90+
BenchmarkStructLevelValidationFailureParallel-4 10000000 169 ns/op 304 B/op 8 allocs/op
91+
BenchmarkStructSimpleCustomTypeSuccess-4 5000000 385 ns/op 32 B/op 2 allocs/op
92+
BenchmarkStructSimpleCustomTypeSuccessParallel-4 20000000 108 ns/op 32 B/op 2 allocs/op
93+
BenchmarkStructSimpleCustomTypeFailure-4 2000000 700 ns/op 424 B/op 9 allocs/op
94+
BenchmarkStructSimpleCustomTypeFailureParallel-4 5000000 241 ns/op 440 B/op 10 allocs/op
95+
BenchmarkStructFilteredSuccess-4 2000000 606 ns/op 288 B/op 9 allocs/op
96+
BenchmarkStructFilteredSuccessParallel-4 10000000 198 ns/op 288 B/op 9 allocs/op
97+
BenchmarkStructFilteredFailure-4 3000000 473 ns/op 256 B/op 7 allocs/op
98+
BenchmarkStructFilteredFailureParallel-4 10000000 158 ns/op 256 B/op 7 allocs/op
99+
BenchmarkStructPartialSuccess-4 2000000 561 ns/op 256 B/op 6 allocs/op
100+
BenchmarkStructPartialSuccessParallel-4 10000000 176 ns/op 256 B/op 6 allocs/op
101+
BenchmarkStructPartialFailure-4 2000000 803 ns/op 480 B/op 11 allocs/op
102+
BenchmarkStructPartialFailureParallel-4 5000000 255 ns/op 480 B/op 11 allocs/op
103+
BenchmarkStructExceptSuccess-4 2000000 868 ns/op 496 B/op 12 allocs/op
104+
BenchmarkStructExceptSuccessParallel-4 10000000 156 ns/op 240 B/op 5 allocs/op
105+
BenchmarkStructExceptFailure-4 2000000 731 ns/op 464 B/op 10 allocs/op
106+
BenchmarkStructExceptFailureParallel-4 10000000 236 ns/op 464 B/op 10 allocs/op
107+
BenchmarkStructSimpleCrossFieldSuccess-4 3000000 412 ns/op 72 B/op 3 allocs/op
108+
BenchmarkStructSimpleCrossFieldSuccessParallel-4 10000000 121 ns/op 72 B/op 3 allocs/op
109+
BenchmarkStructSimpleCrossFieldFailure-4 2000000 661 ns/op 304 B/op 8 allocs/op
110+
BenchmarkStructSimpleCrossFieldFailureParallel-4 10000000 202 ns/op 304 B/op 8 allocs/op
111+
BenchmarkStructSimpleCrossStructCrossFieldSuccess-4 3000000 583 ns/op 80 B/op 4 allocs/op
112+
BenchmarkStructSimpleCrossStructCrossFieldSuccessParallel-4 10000000 167 ns/op 80 B/op 4 allocs/op
113+
BenchmarkStructSimpleCrossStructCrossFieldFailure-4 2000000 852 ns/op 320 B/op 9 allocs/op
114+
BenchmarkStructSimpleCrossStructCrossFieldFailureParallel-4 5000000 257 ns/op 320 B/op 9 allocs/op
115+
BenchmarkStructSimpleSuccess-4 5000000 240 ns/op 0 B/op 0 allocs/op
116+
BenchmarkStructSimpleSuccessParallel-4 20000000 70.7 ns/op 0 B/op 0 allocs/op
117+
BenchmarkStructSimpleFailure-4 2000000 657 ns/op 424 B/op 9 allocs/op
118+
BenchmarkStructSimpleFailureParallel-4 10000000 210 ns/op 424 B/op 9 allocs/op
119+
BenchmarkStructComplexSuccess-4 1000000 1395 ns/op 128 B/op 8 allocs/op
120+
BenchmarkStructComplexSuccessParallel-4 3000000 387 ns/op 128 B/op 8 allocs/op
121+
BenchmarkStructComplexFailure-4 300000 4650 ns/op 3040 B/op 53 allocs/op
122+
BenchmarkStructComplexFailureParallel-4 1000000 1372 ns/op 3040 B/op 53 allocs/op
123123
```
124124

125125
Complimentary Software

‎validator_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6607,7 +6607,7 @@ func TestTranslationErrors(t *testing.T) {
66076607
})
66086608

66096609
NotEqual(t, err, nil)
6610-
Equal(t, err.Error(), "error: conflicting key 'required' rule 'Unknown' with text '{0} is a required field', value being ignored")
6610+
Equal(t, err.Error(), "error: conflicting key 'required' rule 'Unknown' with text '{0} is a required field' for locale 'en', value being ignored")
66116611
}
66126612

66136613
func TestStructFiltered(t *testing.T) {

0 commit comments

Comments
 (0)