Fix: update not found when updating unchanged record (#39)

* update not found spec

* fix mysql driver

Author: Fs02

adapter/mysql/mysql.go

@@ -31,6 +31,14 @@ var _ rel.Adapter = (*Adapter)(nil)
 func Open(dsn string) (*Adapter, error) {
 	var err error
 
+	// force clientFoundRows=true
+	// this allows not found record check when updating a record.
+	if strings.ContainsRune(dsn, '?') {
+		dsn += "&clientFoundRows=true"
+	} else {
+		dsn += "?clientFoundRows=true"
+	}
+
 	adapter := &Adapter{
 		Adapter: &sql.Adapter{
 			Config: &sql.Config{

adapter/mysql/mysql_test.go

@@ -101,6 +101,7 @@ func TestAdapter_specs(t *testing.T) {
 
 	// Update Specs
 	specs.Update(t, repo)
+	specs.UpdateNotFound(t, repo)
 	specs.UpdateHasManyInsert(t, repo)
 	specs.UpdateHasManyUpdate(t, repo)
 	specs.UpdateHasManyReplace(t, repo)
@@ -121,6 +122,20 @@ func TestAdapter_specs(t *testing.T) {
 	specs.ForeignKeyConstraint(t, repo)
 }
 
+func TestAdapter_Open(t *testing.T) {
+	// with parameter
+	assert.NotPanics(t, func() {
+		adapter, _ := Open("root@tcp(localhost:3306)/rel_test?charset=utf8")
+		defer adapter.Close()
+	})
+
+	// without paremeter
+	assert.NotPanics(t, func() {
+		adapter, _ := Open("root@tcp(localhost:3306)/rel_test")
+		defer adapter.Close()
+	})
+}
+
 // func TestAdapter_InsertAll_error(t *testing.T) {
 // 	adapter, err := Open(dsn())
 // 	paranoid.Panic(err, "failed to open database connection")

adapter/postgres/postgres_test.go

@@ -106,6 +106,7 @@ func TestAdapter_specs(t *testing.T) {
 
 	// Update Specs
 	specs.Update(t, repo)
+	specs.UpdateNotFound(t, repo)
 	specs.UpdateHasManyInsert(t, repo)
 	specs.UpdateHasManyUpdate(t, repo)
 	specs.UpdateHasManyReplace(t, repo)

adapter/specs/update.go

@@ -32,6 +32,9 @@ func Update(t *testing.T, repo rel.Repository) {
 	assert.Equal(t, 23, user.Age)
 	assert.Equal(t, &note, user.Note)
 
+	// update unchanged
+	assert.Nil(t, repo.Update(ctx, &user))
+
 	var (
 		queried User
 	)
@@ -42,6 +45,19 @@ func Update(t *testing.T, repo rel.Repository) {
 	assert.Equal(t, user, queried)
 }
 
+// UpdateNotFound tests specification for updating a not found record.
+func UpdateNotFound(t *testing.T, repo rel.Repository) {
+	var (
+		user = User{
+			ID:   0,
+			Name: "update",
+		}
+	)
+
+	// update unchanged
+	assert.Equal(t, rel.NotFoundError{}, repo.Update(ctx, &user))
+}
+
 // UpdateHasManyInsert tests specification for updating a record and inserting has many association.
 func UpdateHasManyInsert(t *testing.T, repo rel.Repository) {
 	var (

adapter/sqlite3/sqlite3_test.go

@@ -104,6 +104,7 @@ func TestAdapter_specs(t *testing.T) {
 
 	// Update Specs
 	specs.Update(t, repo)
+	specs.UpdateNotFound(t, repo)
 	specs.UpdateHasManyInsert(t, repo)
 	specs.UpdateHasManyUpdate(t, repo)
 	specs.UpdateHasManyReplace(t, repo)