CLI: run migration with -mod=mod and add validation (#137)

* CLI: disable read only mod and add validation

* reorder

* use -mod=mod flag

* update codecov action

Author: Fs02

.github/workflows/build.yml

@@ -122,4 +122,4 @@ jobs:
           POSTGRESQL_DATABASE: postgres://rel:rel@localhost/rel_test
         run: go test -race -tags=all -coverprofile=coverage.txt -covermode=atomic ./...
       - name: Codecov
-        uses: codecov/codecov-action@v1.0.13
+        uses: codecov/codecov-action@v1

cmd/rel/internal/migrate.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"flag"
+	"fmt"
 	"html/template"
 	"io"
 	"io/ioutil"
@@ -110,6 +111,10 @@ func ExecMigrate(ctx context.Context, args []string) error {
 
 	fs.Parse(args[2:])
 
+	if *adapter == "" || *driver == "" || *dsn == "" {
+		return fmt.Errorf("rel: missing required parameters:\n\tadapter: %s\n\tdriver: %s\n\tdsn: %s", *adapter, *driver, *dsn)
+	}
+
 	file, err := ioutil.TempFile(tempdir, "rel-*.go")
 	check(err)
 	defer os.Remove(file.Name())
@@ -139,7 +144,7 @@ func ExecMigrate(ctx context.Context, args []string) error {
 	check(err)
 	check(file.Close())
 
-	cmd := exec.CommandContext(ctx, "go", "run", "-mod=readonly", file.Name(), "migrate")
+	cmd := exec.CommandContext(ctx, "go", "run", "-mod=mod", file.Name(), "migrate")
 	cmd.Stdout = stdout
 	cmd.Stderr = stderr
 	return cmd.Run()

cmd/rel/internal/migrate_test.go

@@ -11,12 +11,27 @@ import (
 )
 
 func TestExecMigrate(t *testing.T) {
+	t.Run("missing required parameters", func(t *testing.T) {
+		var (
+			ctx  = context.TODO()
+			args = []string{
+				"rel",
+				"migrate",
+			}
+		)
+
+		assert.Equal(t, errors.New("rel: missing required parameters:\n\tadapter: \n\tdriver: \n\tdsn: "), ExecMigrate(ctx, args))
+	})
+
 	t.Run("invalid migration dir", func(t *testing.T) {
 		var (
 			ctx  = context.TODO()
 			args = []string{
 				"rel",
 				"migrate",
+				"-adapter=github.com/go-rel/rel/adapter/sqlite3",
+				"-driver=github.com/mattn/go-sqlite3",
+				"-dsn=:memory:",
 				"-dir=db",
 			}
 		)

cmd/rel/internal/util.go

@@ -21,6 +21,10 @@ func getDatabaseInfo() (string, string, string) {
 		adapter = os.Getenv("DATABASE_ADAPTER")
 		driver = os.Getenv("DATABASE_DRIVER")
 		dsn = os.Getenv("DATABASE_URL")
+	case os.Getenv("SQLITE3_DATABASE") != "":
+		adapter = "github.com/go-rel/rel/adapter/sqlite3"
+		driver = "github.com/mattn/go-sqlite3"
+		dsn = os.Getenv("SQLITE3_DATABASE")
 	case os.Getenv("MYSQL_HOST") != "":
 		adapter = "github.com/go-rel/rel/adapter/mysql"
 		driver = "github.com/go-sql-driver/mysql"
@@ -39,10 +43,15 @@ func getDatabaseInfo() (string, string, string) {
 			os.Getenv("POSTGRES_HOST"),
 			os.Getenv("POSTGRES_PORT"),
 			os.Getenv("POSTGRES_DATABASE"))
-	case os.Getenv("SQLITE3_DATABASE") != "":
-		adapter = "github.com/go-rel/rel/adapter/sqlite3"
-		driver = "github.com/mattn/go-sqlite3"
-		dsn = os.Getenv("SQLITE3_DATABASE")
+	case os.Getenv("POSTGRESQL_HOST") != "":
+		adapter = "github.com/go-rel/rel/adapter/postgres"
+		driver = "github.com/lib/pq"
+		dsn = fmt.Sprintf("postgres://%s:%s@%s:%s/%s?sslmode=disable",
+			os.Getenv("POSTGRESQL_USERNAME"),
+			os.Getenv("POSTGRESQL_PASSWORD"),
+			os.Getenv("POSTGRESQL_HOST"),
+			os.Getenv("POSTGRESQL_PORT"),
+			os.Getenv("POSTGRESQL_DATABASE"))
 	}
 
 	return adapter, driver, dsn

cmd/rel/internal/util_test.go

@@ -63,6 +63,25 @@ func TestGetDatabaseInfo(t *testing.T) {
 		assert.Equal(t, "postgres://user:password@localhost:5432/db?sslmode=disable", url)
 	})
 
+	t.Run("postgresql alternative", func(t *testing.T) {
+		os.Setenv("POSTGRESQL_HOST", "localhost")
+		os.Setenv("POSTGRESQL_PORT", "5432")
+		os.Setenv("POSTGRESQL_DATABASE", "db")
+		os.Setenv("POSTGRESQL_USERNAME", "user")
+		os.Setenv("POSTGRESQL_PASSWORD", "password")
+
+		defer os.Setenv("POSTGRESQL_HOST", "")
+		defer os.Setenv("POSTGRESQL_PORT", "")
+		defer os.Setenv("POSTGRESQL_DATABASE", "")
+		defer os.Setenv("POSTGRESQL_USERNAME", "")
+		defer os.Setenv("POSTGRESQL_PASSWORD", "")
+
+		adapter, driver, url := getDatabaseInfo()
+		assert.Equal(t, "github.com/go-rel/rel/adapter/postgres", adapter)
+		assert.Equal(t, "github.com/lib/pq", driver)
+		assert.Equal(t, "postgres://user:password@localhost:5432/db?sslmode=disable", url)
+	})
+
 	t.Run("sqlite3", func(t *testing.T) {
 		os.Setenv("SQLITE3_DATABASE", "test.db")
 		defer os.Setenv("SQLITE3_DATABASE", "")