Skip to content

Commit 25cf587

Browse files
committed
sequenceNr -> sequence
1 parent 44d7dee commit 25cf587

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

compress_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ func TestRoundtrip(t *testing.T) {
9898

9999
for _, test := range tests {
100100
t.Run(test.desc, func(t *testing.T) {
101-
cSend.resetSequenceNr()
102-
cReceive.resetSequenceNr()
101+
cSend.resetSequence()
102+
cReceive.resetSequence()
103103

104104
uncompressed := roundtripHelper(t, cSend, cReceive, test.uncompressed)
105105
if !bytes.Equal(uncompressed, test.uncompressed) {

connection.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,13 @@ func (mc *mysqlConn) writeWithTimeout(b []byte) (int, error) {
8484
return mc.netConn.Write(b)
8585
}
8686

87-
func (mc *mysqlConn) resetSequenceNr() {
87+
func (mc *mysqlConn) resetSequence() {
8888
mc.sequence = 0
8989
mc.compressSequence = 0
9090
}
9191

92-
// syncSequenceNr must be called when finished writing some packet and before start reading.
93-
func (mc *mysqlConn) syncSequenceNr() {
92+
// syncSequence must be called when finished writing some packet and before start reading.
93+
func (mc *mysqlConn) syncSequence() {
9494
// Syncs compressionSequence to sequence.
9595
// This is not documented but done in `net_flush()` in MySQL and MariaDB.
9696
// https://github.com/mariadb-corporation/mariadb-connector-c/blob/8228164f850b12353da24df1b93a1e53cc5e85e9/libmariadb/ma_net.c#L170-L171

infile.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func (mc *okHandler) handleInFileRequest(name string) (err error) {
172172
if ioErr := mc.conn().writePacket(data[:4]); ioErr != nil {
173173
return ioErr
174174
}
175-
mc.conn().syncSequenceNr()
175+
mc.conn().syncSequence()
176176

177177
// read OK packet
178178
if err == nil {

packets.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ func (mc *mysqlConn) writeAuthSwitchPacket(authData []byte) error {
431431

432432
func (mc *mysqlConn) writeCommandPacket(command byte) error {
433433
// Reset Packet Sequence
434-
mc.resetSequenceNr()
434+
mc.resetSequence()
435435

436436
data, err := mc.buf.takeSmallBuffer(4 + 1)
437437
if err != nil {
@@ -447,7 +447,7 @@ func (mc *mysqlConn) writeCommandPacket(command byte) error {
447447

448448
func (mc *mysqlConn) writeCommandPacketStr(command byte, arg string) error {
449449
// Reset Packet Sequence
450-
mc.resetSequenceNr()
450+
mc.resetSequence()
451451

452452
pktLen := 1 + len(arg)
453453
data, err := mc.buf.takeBuffer(pktLen + 4)
@@ -463,13 +463,13 @@ func (mc *mysqlConn) writeCommandPacketStr(command byte, arg string) error {
463463

464464
// Send CMD packet
465465
err = mc.writePacket(data)
466-
mc.syncSequenceNr()
466+
mc.syncSequence()
467467
return err
468468
}
469469

470470
func (mc *mysqlConn) writeCommandPacketUint32(command byte, arg uint32) error {
471471
// Reset Packet Sequence
472-
mc.resetSequenceNr()
472+
mc.resetSequence()
473473

474474
data, err := mc.buf.takeSmallBuffer(4 + 1 + 4)
475475
if err != nil {
@@ -952,7 +952,7 @@ func (stmt *mysqlStmt) writeCommandLongData(paramID int, arg []byte) error {
952952
pktLen = dataOffset + argLen
953953
}
954954

955-
stmt.mc.resetSequenceNr()
955+
stmt.mc.resetSequence()
956956
// Add command byte [1 byte]
957957
data[4] = comStmtSendLongData
958958

@@ -976,7 +976,7 @@ func (stmt *mysqlStmt) writeCommandLongData(paramID int, arg []byte) error {
976976
}
977977

978978
// Reset Packet Sequence
979-
stmt.mc.resetSequenceNr()
979+
stmt.mc.resetSequence()
980980
return nil
981981
}
982982

@@ -1001,7 +1001,7 @@ func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {
10011001
}
10021002

10031003
// Reset packet-sequence
1004-
mc.resetSequenceNr()
1004+
mc.resetSequence()
10051005

10061006
var data []byte
10071007
var err error
@@ -1218,7 +1218,7 @@ func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {
12181218
}
12191219

12201220
err = mc.writePacket(data)
1221-
mc.syncSequenceNr()
1221+
mc.syncSequence()
12221222
return err
12231223
}
12241224

0 commit comments

Comments
 (0)