The new rm command available in task fails if files don't exist and -f is used

[fgimian]

Description

When using the regular coreutils rm command, a -f flag will not fail if files do not exist, but with the version shipped with task, this does fail as follows:

~\source\totalmix-volume-control on  main took 2s
🕙 [ 12:04:40 PM ] ❯ task example
task: [example] rm -f src/*/TestResults/*/coverage.cobertura.xml

~\source\totalmix-volume-control on  main [!]
🕙 [ 12:04:44 PM ] ❯ task example
task: [example] rm -f src/*/TestResults/*/coverage.cobertura.xml
task: Failed to run task "example": remove C:\Users\Fots\source\totalmix-volume-control\src\*\TestResults\*\coverage.cobertura.xml: The filename, directory name, or volume label syntax is incorrect.

The help for rm does even mention that inexistent files should be ignored but there seems to be a little bug here:

task: [test] rm --help
Usage: rm [-Rrvif] file...
  -R    Recursive, remove hierarchies
  -f    Force, ignore nonexistent files and never prompt
  -i    Interactive mode.
  -r    equivalent to -R
  -v    Verbose mode.

Version

3.45.4

Operating system

Windows 11 Pro

Experiments Enabled

No response

Example Taskfile

version: "3"

tasks:
  example:
    cmds:
      - rm -f src/*/TestResults/*/coverage.cobertura.xml

[pd93]

Unfortunately, I'm not able to reproduce this on my copy of Windows 11 with either Powershell nor cmd. The example you gave runs with no errors and exits with no effect as intended.

[fgimian]

Hmm that's unusual, I even had the problem on CI (GitHub Actions). Please see the failing pipeline and the respective workflow definition along with the Taskfile.

Cheers
Fotis

[ngorke]

I am also experiencing this issue, and unable to reproduce it using the taskfile provided by @fgimian. It seems to occur when globbing a subdirectory, and when no files match the glob. However, I am able to reproduce this issue using the following taskfile in an empty directory:

version: "3"
tasks:
  passglob:
    cmds:
      - rm -rf test
      - mkdir -p test/a/foo
      - rm -rf test/**/foo
  failglob:
    cmds:
      - rm -rf test
      - mkdir -p test/a
      - rm -rf test/**/foo

Running the passglob task succeeds every time, while running the failglob task fails every time.

[pd93]

Thanks for the repro @ngorke. I am seeing the same thing now.

FWIW. I thought this might be related to needing shopt: [globstar] to use **, but the error happens using a single * too.

cc @andreynering.