fix: only check for updates on activation, not refresh

Author: pd93

src/extension.ts

@@ -13,7 +13,7 @@ export function activate(context: vscode.ExtensionContext) {
 	taskExtension.registerListeners(context);
 
 	// Refresh the tasks list
-	taskExtension.updateAndRefresh();
+	taskExtension.refresh();
 }
 
 export function deactivate() { }

src/services/taskfile.ts

@@ -35,7 +35,10 @@ class TaskfileService {
         return `${settings.path} ${command}`;
     }
 
-    public async checkInstallation(): Promise<string> {
+    public async checkInstallation(checkForUpdates?: boolean): Promise<string> {
+        if (checkForUpdates === undefined) {
+            checkForUpdates = settings.checkForUpdates;
+        }
         return await new Promise((resolve) => {
             let command = this.command('--version');
             cp.exec(command, (_, stdout: string, stderr: string) => {
@@ -65,7 +68,7 @@ class TaskfileService {
 
                 // If a newer version is available, show a message
                 // TODO: what happens if the user is offline?
-                if (settings.checkForUpdates) {
+                if (checkForUpdates) {
                     this.getLatestVersion().then((latestVersion) => {
                         if (version && latestVersion && version.compare(latestVersion) < 0) {
                             log.info(`A new version of Task is available. Current version: v${version}, Latest version: v${latestVersion}`);
@@ -77,6 +80,8 @@ class TaskfileService {
                         return resolve("notInstalled");
                     });
                 }
+
+                return resolve("ready");
             });
         });
     }

src/task.ts

@@ -15,9 +15,9 @@ export class TaskExtension {
         this.setTreeNesting(settings.treeNesting);
     }
 
-    public async update(): Promise<void> {
+    public async update(checkForUpdates?: boolean): Promise<void> {
         // Do version checks
-        await services.taskfile.checkInstallation().then((status): Promise<PromiseSettledResult<models.Taskfile>[]> => {
+        await services.taskfile.checkInstallation(checkForUpdates).then((status): Promise<PromiseSettledResult<models.Taskfile>[]> => {
 
             // Set the status
             vscode.commands.executeCommand('setContext', 'vscode-task:status', status);
@@ -43,13 +43,9 @@ export class TaskExtension {
         });
     }
 
-    public refresh(): void {
-        this._activityBar.refresh(this._taskfiles);
-    }
-
-    public async updateAndRefresh(): Promise<void> {
-        await this.update().then(() => {
-            this.refresh();
+    public async refresh(checkForUpdates?: boolean): Promise<void> {
+        await this.update(checkForUpdates).then(() => {
+            this._activityBar.refresh(this._taskfiles);
         }).catch((err: string) => {
             log.error(err);
         });
@@ -86,7 +82,7 @@ export class TaskExtension {
         // Refresh tasks
         context.subscriptions.push(vscode.commands.registerCommand('vscode-task.refresh', () => {
             log.info("Command: vscode-task.refresh");
-            this.updateAndRefresh();
+            this.refresh(false);
         }));
 
         // View tasks as list
@@ -200,7 +196,7 @@ export class TaskExtension {
         log.info("Detected changes to taskfile");
         // If manual updating is turned off (update on save)
         if (settings.updateOn !== "manual") {
-            await this.updateAndRefresh();
+            await this.refresh(false);
         }
     }