fix: rename configuration key

Author: pd93

src/task.ts

@@ -5,7 +5,7 @@ import { ActivityBar } from './elements/activityBar.js';
 import { Namespace, Task } from './models/models.js';
 import { taskfileSvc } from './services/taskfile.js';
 import { log } from './utils/log.js';
-import { settings, UpdateOn } from './utils/settings.js';
+import { configKey, oldConfigKey, settings, UpdateOn } from './utils/settings.js';
 
 export class TaskExtension {
     private _taskfiles: Namespace[] = [];
@@ -289,7 +289,7 @@ export class TaskExtension {
 
     private _onDidChangeConfiguration(event: vscode.ConfigurationChangeEvent) {
         log.info("Detected changes to configuration");
-        if (event.affectsConfiguration("task")) {
+        if (event.affectsConfiguration(configKey) || event.affectsConfiguration(oldConfigKey)) {
             settings.update();
             this._nesting = settings.tree.nesting;
             this._status = settings.tree.status;

src/utils/settings.ts

@@ -1,9 +1,23 @@
 import * as vscode from 'vscode';
 import { log } from './log.js';
 
+export const configKey = "taskfile";
+export const oldConfigKey = "task";
+const oldConfigKeys = [
+    "updateOn",
+    "path",
+    "outputTo",
+    "checkForUpdates",
+    "doubleClickTimeout",
+    "tree.nesting",
+    "tree.status",
+    "tree.sort",
+    "terminal.per",
+    "terminal.close",
+];
+
 class Settings {
     private static _instance: Settings;
-    private static namespace = "taskfile";
     public updateOn!: UpdateOn;
     public path!: string;
     public outputTo!: OutputTo;
@@ -25,17 +39,17 @@ class Settings {
         log.info("Updating settings");
 
         // Check if the old configuration still exists
-        let oldConfig = vscode.workspace.getConfiguration("task");
-        if (oldConfig) {
-            vscode.window.showWarningMessage(`Task changed its configuration namespace from "task" to "taskfile". Your task settings will not be applied until you update your settings accordingly.`, "More Info").then(selection => {
+        const oldConfig = vscode.workspace.getConfiguration(oldConfigKey);
+        if (oldConfigKeys.some(key => oldConfig.has(key))) {
+            vscode.window.showWarningMessage(`Task changed its configuration namespace from "${oldConfigKey}" to "${configKey}". Your task settings will not be applied until you update your settings accordingly.`, "More Info").then(selection => {
                 if (selection === "More Info") {
                     vscode.env.openExternal(vscode.Uri.parse("https://taskfile.dev/docs/integrations#configuration-namespace-change"));
                 }
             });
         }
 
         // Get the workspace config
-        let config = vscode.workspace.getConfiguration(Settings.namespace);
+        let config = vscode.workspace.getConfiguration(configKey);
 
         // Set the properties
         this.updateOn = config.get("updateOn") ?? UpdateOn.save;
@@ -77,7 +91,7 @@ class TreeSettings {
         log.info("Updating tree settings");
 
         // Get the workspace config
-        let config = vscode.workspace.getConfiguration("task");
+        let config = vscode.workspace.getConfiguration(configKey);
 
         // Set the properties
         this.nesting = config.get("tree.nesting") ?? true;
@@ -110,7 +124,7 @@ class TerminalSettings {
         log.info("Updating terminal settings");
 
         // Get the workspace config
-        let config = vscode.workspace.getConfiguration("task");
+        let config = vscode.workspace.getConfiguration(configKey);
 
         // Set the properties
         this.per = config.get("terminal.per") ?? TerminalPer.window;